[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] msvcr120/tests: Add critical section test.
From:       Francois Gouget <fgouget () free ! fr>
Date:       2016-03-29 2:21:31
Message-ID: alpine.DEB.2.20.1603290411370.29484 () amboise
[Download RAW message or body]

On Tue, 22 Mar 2016, Piotr Caban wrote:

> On 03/22/16 17:28, YongHao Hu wrote:
> > How long is a test running acceptable? I want to know a appropriate
> > standard.
> There's no rule for that. In most cases 100ms wait is long enough to 
> make sure something works. Of course if the test is useful and it can't 
> be written to end quickly it can take much longer. I'm trying to avoid 
> tests that calls Sleep if possible.

The TestBot and WineTest impose a 2 minute limit on individual tests 
(like msvcr120:msvcr120 or kernel32:process).

Furthermore the TestBot imposes a 30 minute limit on the full test 
suite. At 585 tests (and growing all the time), this only allows an 
average of about 3 seconds per test. But of course some tests take much 
longer so the remainder must be much faster to bring the average down.

-- 
Francois Gouget <fgouget@free.fr>              http://fgouget.free.fr/
               If you think the whole world revolves around you,
                 quit staring at the GPS display while driving.



[prev in list] [next in list] [prev in thread] [next in thread]