[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: secur32: Remove a dead assignment (Clang)
From:       André_Hentschel <nerv () dawncrow ! de>
Date:       2015-11-30 19:29:53
Message-ID: 565CA3B1.5050109 () dawncrow ! de
[Download RAW message or body]

Am 30.11.2015 um 15:10 schrieb Lauri Kenttä:
> On 2015-11-29 23:31, André Hentschel wrote:
>> -    pfQOP = &fQOP;
> 
> Surely nobody would write that kind of dead assignment if there wasn't some intended function for it.
> 
> I wonder if this was supposed to be:
> 
> if (pfQOP)
>   *pfQOP = fQOP;
> 
> After all, the parameter is designated as _Out_ in MSDN.
> 

I recently met the author, if only I've seen it before :)
CCing him, though I doubt he can remember his code from 2006
And you're right, maybe it's rather something like:
    if (pfQOP)
        *pfQOP = 0;



[prev in list] [next in list] [prev in thread] [next in thread]