[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: wininet: Fix allocation error handling (Clang)
From:       André_Hentschel <nerv () dawncrow ! de>
Date:       2015-11-30 19:29:51
Message-ID: 565CA3AF.4060001 () dawncrow ! de
[Download RAW message or body]

Am 30.11.2015 um 11:47 schrieb Jacek Caban:
> Hi André,
> 
> On 11/29/15 19:53, André Hentschel wrote:
>> diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c
>> index 4784b33..0b7f5e1 100644
>> --- a/dlls/wininet/cookie.c
>> +++ b/dlls/wininet/cookie.c
>> @@ -713,7 +713,8 @@ DWORD get_cookie_header(const WCHAR *host, const WCHAR *path, WCHAR **ret)
>>  
>>              *ret = header;
>>          }else {
>> -            res = ERROR_NOT_ENOUGH_MEMORY;
>> +            LeaveCriticalSection(&cookie_cs);
>> +            return ERROR_NOT_ENOUGH_MEMORY;
> 
> How about returning res in the bottom of the function?

Good point, thx




[prev in list] [next in list] [prev in thread] [next in thread]