[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] wined3d: fix Unrecognized usage flags
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2015-04-29 7:12:27
Message-ID: CAOsNvwy1SUSToqbgq5xO2-C-3mqPA64+hBWgBPmNTJNkFMRHwg () mail ! gmail ! com
[Download RAW message or body]

Please use git send-email for sending patches.

On 28 April 2015 at 09:18, Sergey Isakov <isakov-sl@bk.ru> wrote:
> +    WINED3DUSAGE_TO_STR(WINED3DUSAGE_TEXTURE);
This is fine, but WINED3DUSAGE_OWNDC is missing here as well. Is "buf"
still larger enough after you add these flags?

> -    if (usage) FIXME("Unrecognized usage flag(s) %#x\n", usage);
> +    if (usage & ~WINED3DUSAGE_QUERY_MASK) FIXME("Unrecognized usage flag(s) %#x\n", usage);
I think it makes more sense to do this in the caller. It may make even
more sense to just merge debug_d3dusage() and debug_d3dusagequery().


[prev in list] [next in list] [prev in thread] [next in thread]