[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: qmgr/tests: Skip tests on Windows instead of failing
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2013-11-29 19:21:11
Message-ID: 5298E927.8090203 () gmail ! com
[Download RAW message or body]

On 11/29/2013 23:12, Andr=E9 Hentschel wrote:
> Some w2k and win7 machines...
> ---
>   dlls/qmgr/tests/enum_files.c | 2 +-
>   dlls/qmgr/tests/file.c       | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/qmgr/tests/enum_files.c b/dlls/qmgr/tests/enum_files.c
> index 7e2ab1e..a77f1e7 100644
> --- a/dlls/qmgr/tests/enum_files.c
> +++ b/dlls/qmgr/tests/enum_files.c
> @@ -256,7 +256,7 @@ START_TEST(enum_files)
>           /* Keep state separate between tests. */
>           if (!setup())
>           {
> -            ok(0, "tests:%d: Unable to setup test\n", i);
> +            win_skip("tests:%d: Unable to setup test, skipping tests\n",=
 i);
>               break;
>           }
I guess it's just fails to create an manager instance, please add a copy =

of test_create_manager() for that.

> +++ b/dlls/qmgr/tests/file.c
> @@ -197,7 +197,7 @@ START_TEST(file)
>           /* Keep state separate between tests. */
>           if (!setup())
>           {
> -            ok(0, "tests:%d: Unable to setup test\n", i);
> +            win_skip("tests:%d: Unable to setup test, skipping tests\n",=
 i);
>               break;
>           }
>           (*test)();
This one is different as file.c already skips everything if initial =

object creation fails. We need to know where setup() fails exactly.


[prev in list] [next in list] [prev in thread] [next in thread]