[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/3] wined3d: Pass a struct wined3d_bo_address to read_from_framebuffer.
From:       Stefan_Dösinger <stefandoesinger () gmail ! com>
Date:       2013-11-28 17:35:33
Message-ID: CA+bGHb_r8c6C7cYbsoa1_NZGuP_Q8RLDr-9HPV1=oY-DrU3g-w () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Am 28.11.2013 17:07 schrieb "Stefan D=C3=B6singer" <stefandoesinger@gmail.c=
om>:
>
>
> Am 28.11.2013 um 15:56 schrieb Henri Verbeet <hverbeet@gmail.com>:
>
> > On 28 November 2013 10:48, Stefan D=C3=B6singer <stefan@codeweavers.com=
>
wrote:
> >> /* Read the framebuffer back into the surface */
> >> -static void read_from_framebuffer(struct wined3d_surface *surface,
void *dest, UINT pitch)
> >> +static void read_from_framebuffer(struct wined3d_surface *surface,
> >> +        const struct wined3d_bo_address *data, UINT pitch)
> > It seems a bit silly to pass these as parameters when the only caller
> > gets them from the surface.
> It keeps the switch between resource->allocatedMemory and PBO in a
central place. My goal is to remove resource->allocatedMemory and have
surface_get_data and surface_map choose between PBO, heap_memory,
user-memory set by surface_set_memory and the DIB.
>
I guess you meant that I can call surface_get_memory in the function
itself...

[Attachment #5 (text/html)]

<p dir="ltr"><br>
Am 28.11.2013 17:07 schrieb &quot;Stefan Dösinger&quot; &lt;<a \
href="mailto:stefandoesinger@gmail.com">stefandoesinger@gmail.com</a>&gt;:<br> \
&gt;<br> &gt;<br>
&gt; Am 28.11.2013 um 15:56 schrieb Henri Verbeet &lt;<a \
href="mailto:hverbeet@gmail.com">hverbeet@gmail.com</a>&gt;:<br> &gt;<br>
&gt; &gt; On 28 November 2013 10:48, Stefan Dösinger &lt;<a \
href="mailto:stefan@codeweavers.com">stefan@codeweavers.com</a>&gt; wrote:<br> &gt; \
&gt;&gt; /* Read the framebuffer back into the surface */<br> &gt; &gt;&gt; -static \
void read_from_framebuffer(struct wined3d_surface *surface, void *dest, UINT \
pitch)<br> &gt; &gt;&gt; +static void read_from_framebuffer(struct wined3d_surface \
*surface,<br> &gt; &gt;&gt; +            const struct wined3d_bo_address *data, UINT \
pitch)<br> &gt; &gt; It seems a bit silly to pass these as parameters when the only \
caller<br> &gt; &gt; gets them from the surface.<br>
&gt; It keeps the switch between resource-&gt;allocatedMemory and PBO in a central \
place. My goal is to remove resource-&gt;allocatedMemory and have surface_get_data \
and surface_map choose between PBO, heap_memory, user-memory set by \
surface_set_memory and the DIB.<br>

&gt;<br>
I guess you meant that I can call surface_get_memory in the function itself...<br>
</p>





[prev in list] [next in list] [prev in thread] [next in thread]