[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [1/2] DWrite: Implemented functions regarding text alignment. (try 3)
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2013-05-31 18:17:56
Message-ID: CAG4Z_JJE0UhWJjRf7NX1qqUbOML_V0fa93zPP8PMsynopzKHyw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Fri, May 31, 2013 at 9:07 PM, Fabian Müntefering <Cookiezzz97@gmx.de>wrote:

> Implemented functions of text format and text layout regarding text
> alignment.
>
> Try 3: Used proper enum value to set the enum variables.
>
>
>
>
>
+    if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER &&
alignment!=DWRITE_TEXT_ALIGNMENT_LEADING &&
+       alignment!=DWRITE_TEXT_ALIGNMENT_JUSTIFIED &&
alignment!=DWRITE_TEXT_ALIGNMENT_TRAILING)
+        return E_INVALIDARG;
+    This->format.text_align = alignment;

This doesn't look great, you'll need a test that shows it really
rejects meaningless values,
and if it does it would be simpler to compare with greatest enum value.

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, \
May 31, 2013 at 9:07 PM, Fabian Müntefering <span dir="ltr">&lt;<a \
href="mailto:Cookiezzz97@gmx.de" target="_blank">Cookiezzz97@gmx.de</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Implemented functions \
of text format and text layout regarding text<br> alignment.<br>
<br>
Try 3: Used proper enum value to set the enum variables.<br>
<br>
<br><br>
<br></blockquote></div><br><pre>+    if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER \
&amp;&amp; alignment!=DWRITE_TEXT_ALIGNMENT_LEADING &amp;&amp; +       \
alignment!=DWRITE_TEXT_ALIGNMENT_JUSTIFIED &amp;&amp; \
alignment!=DWRITE_TEXT_ALIGNMENT_TRAILING) +        return E_INVALIDARG;
+    This-&gt;format.text_align = alignment;<br><br></pre><pre>This doesn&#39;t look \
great, you&#39;ll need a test that shows it really rejects meaningless values,<br>and \
if it does it would be simpler to compare with greatest enum value.<br> \
</pre></div></div>





[prev in list] [next in list] [prev in thread] [next in thread]