[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ole32: Add a basic OLE client/server test suite. Take 2.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2013-05-31 17:07:47
Message-ID: 87li6v5b8c.fsf () wine ! dyndns ! org
[Download RAW message or body]

Dmitry Timoshkov <dmitry@baikal.ru> writes:

> Dmitry Timoshkov <dmitry@baikal.ru> wrote:
>
>> With minor clean ups and with increased timeout to wait for server termination
>> to please some really slow VMs (that allowed to remove broken() statements).
>
> It would be helpful to provide some feedback and explain the 'pending' state
> of the patch which adds a test.

It seems to be awfully complicated. In particular I don't think you need
a shared mapping plus a pipe plus a mutex just to log tracing
output. Redefining standard macros is also not a good idea.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]