[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 4/5] d3drm: Avoid LPDIRECT3DRMTEXTURE.
From:       Christian Costa <titan.costa () gmail ! com>
Date:       2013-05-27 13:02:35
Message-ID: CAMo6X8aPBfmiKXmAp-Y4eiqPcVLivsv0MLpPOnLKjNxrUA92Gg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


2013/5/27 Henri Verbeet <hverbeet@gmail.com>

> On 27 May 2013 13:19, Christian Costa <titan.costa@gmail.com> wrote:
> > Original ddraw/d3d used
> > the same format as d3drm until you changed it (as well as methods names=
).
> This is perhaps slightly bad form, but since you're pressing the
> point: Yes, and those were hardly the only things that were wrong with
> it.
>
> This is your point of view.


> > Since you're working on
> > it that's not a problem but there is no need to change other dlls if
> you're
> > not working on them.
> Clearly I'm working on it now. However, if what you're actually saying
> is that you're claiming maintainership over d3drm that's ok, but then
> I'd also like to see some actual maintenance.
>

Andr=E9 and I have been working on it so far when needed so yes.
I'm wondering what work you're doing. So far I've only seen some cleanup
like LP stuff removal.
That would be better to see real code before cleaning the code to suit your
taste.
And anyway if I had to work again on d3drm after you changed all the traces
or whatever,
should I change all traces back to something I prefer because I'm working
on it, forgetting people that may
have recently worked or still working on it? If you think your traces are
better that would be better to convince people and put
something in the coding guideline. Currently there is no parenthesis
whereas all code in wine use them for tracing function call
and this make log lines longer which some was arguing it was a bad thing.

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2013/5/27 Henri \
Verbeet <span dir="ltr">&lt;<a href="mailto:hverbeet@gmail.com" \
target="_blank">hverbeet@gmail.com</a>&gt;</span><br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
class="im">On 27 May 2013 13:19, Christian Costa &lt;<a \
href="mailto:titan.costa@gmail.com">titan.costa@gmail.com</a>&gt; wrote:<br> &gt; \
Original ddraw/d3d used<br> &gt; the same format as d3drm until you changed it (as \
well as methods names).<br> </div>This is perhaps slightly bad form, but since \
                you&#39;re pressing the<br>
point: Yes, and those were hardly the only things that were wrong with<br>
it.<br>
<div class="im"><br></div></blockquote><div>This is your point of \
view.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"> &gt; Since \
you&#39;re working on<br> &gt; it that&#39;s not a problem but there is no need to \
change other dlls if you&#39;re<br> &gt; not working on them.<br>
</div>Clearly I&#39;m working on it now. However, if what you&#39;re actually \
saying<br> is that you&#39;re claiming maintainership over d3drm that&#39;s ok, but \
then<br> I&#39;d also like to see some actual maintenance.<br>
</blockquote></div><br></div><div class="gmail_extra">André and I have been working \
on it so far when needed so yes.<br></div><div class="gmail_extra">I&#39;m wondering \
what work you&#39;re doing. So far I&#39;ve only seen some cleanup like LP stuff \
removal.<br> </div><div class="gmail_extra">That would be better to see real code \
before cleaning the code to suit your taste.<br></div><div class="gmail_extra">And \
anyway if I had to work again on d3drm after you changed all the traces or \
whatever,<br> should I change all traces back to something I prefer because I&#39;m \
working on it, forgetting people that may<br>have recently worked or still working on \
it? If you think your traces are better that would be better to convince people and \
put<br> </div><div class="gmail_extra">something in the coding guideline. Currently \
there is no parenthesis whereas all code in wine use them for tracing function \
call<br></div><div class="gmail_extra">and this make log lines longer which some was \
arguing it was a bad thing.<br> </div></div>





[prev in list] [next in list] [prev in thread] [next in thread]