[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] winemp3.acm: always dynamically load libmpg123 stuff
From:       Chris Robinson <chris.kcat () gmail ! com>
Date:       2010-02-28 23:11:22
Message-ID: 201002281511.23060.chris.kcat () gmail ! com
[Download RAW message or body]

On Sunday 28 February 2010 1:13:44 pm Marcus Meissner wrote:
> Hi,
> 
> Copy in the mpg123.h header from the library so we do not need it for
> building. (it is also LPGL)
> 
> Dynamically link from libmpg123.so.0.
> (Chances are very good that ABI stays stable.)
> 
> This allows me providing a MP3 capable Wine build for openSUSE without
> actually having libmpg123 in the openSUSE buildservice for building.
> 
> 
> I was not able to test it though, anyone have a working winemp3.acm
> using testcase :(

This won't work, unfortunately. The mpg123.h header does some evil macro hacks 
to forward certain functions (eg. mpg123_seek, mpg123_feedseek) to 64-bit 
variants when _FILE_OFFSET_BITS is 64 due to using off_t. The functions the 
lib has depends on whether it was built with _FILE_OFFSET_BITS=64 or not, and 
the macros won't affect the strings passed to wine_dlsym.

It also looks like the lib isn't unloaded with the acm.


[prev in list] [next in list] [prev in thread] [next in thread]