[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 06/12] d3d10: Implement ID3D10EffectType::GetMemberName().
From:       Rico_Schüller <kgbricola () web ! de>
Date:       2009-09-28 19:22:24
Message-ID: 4AC10CF0.2050900 () web ! de
[Download RAW message or body]

Am 28.09.2009 15:08, schrieb Henri Verbeet:
>>   static LPCSTR STDMETHODCALLTYPE d3d10_effect_type_GetMemberName(ID3D10EffectType *iface, UINT index)
>>   {
>> -    FIXME("iface %p, index %u stub!\n", iface, index);
>> +    struct d3d10_effect_type *This = (struct d3d10_effect_type *)iface;
>>
>> -    return NULL;
>> +    TRACE("iface %p, index %u\n", iface, index);
>> +
>> +    if(index>= This->member_count) return NULL;
>> +
>> +    return This->members[index].name;
>>   }
>>      
> You can't do this yet, it needs to work for types created by
> parse_fx10_type() as well. The same goes for patches 7-11. Patches 1-5
> look ok to me, and can stand on their own.
>
>
>
>    
I'll improve the whole patch set.

Cheers
Rico


[prev in list] [next in list] [prev in thread] [next in thread]