[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: mshtml: Implement IHTMLElement get_document
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2008-10-30 12:14:10
Message-ID: 4909A512.5080107 () codeweavers ! com
[Download RAW message or body]

Hi Alistair,

Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
>     mshtml: Implement IHTMLElement get_document
>

+    *p = NULL;
+
+    if(!This->node.doc->nsdoc) {
+        WARN("NULL nsdoc\n");
+        return E_UNEXPECTED;
+    }


You don't use nsdoc so there is no reason to test it.

+    hr = IHTMLDocument2_QueryInterface(HTMLDOC(This->node.doc), &IID_IHTMLDocument, (void**)p);
+
+    return hr;



You could just cast This->node.doc to IHTMLDocument and call AddRef on result.


Jacek



[prev in list] [next in list] [prev in thread] [next in thread]