[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/3] fusion: Implement the IAssemblyEnum interface. [try3]
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2008-10-30 12:05:20
Message-ID: 4909A300.8030709 () codeweavers ! com
[Download RAW message or body]

Hi James,

James Hawkins wrote:
> ---
>  dlls/fusion/Makefile.in  |    1 +
>  dlls/fusion/asmcache.c   |   83 ----------
>  dlls/fusion/asmenum.c    |  385 ++++++++++++++++++++++++++++++++++++++++++++++
>  dlls/fusion/asmname.c    |   15 +--
>  dlls/fusion/fusion.c     |   12 --
>  dlls/fusion/fusionpriv.h |   15 ++
>  6 files changed, 402 insertions(+), 109 deletions(-)
>  create mode 100644 dlls/fusion/asmenum.c
>   

+
+done:
+    FindClose(hfind);
+    return S_OK;
+}
+

You always set hr in error paths so I guess you want to return it here.

Also, it's a matter of style, but these gotos look strange. You could 
replace them all by break statements.


Jacek


[prev in list] [next in list] [prev in thread] [next in thread]