[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: user[2/2]: Preserve LastError.
From:       Vitaliy Margolen <wine-devel () kievinfo ! com>
Date:       2006-07-30 16:39:16
Message-ID: 1484219973.20060730103916 () kievinfo ! com
[Download RAW message or body]

Sunday, July 30, 2006, 6:29:43 AM, Detlef Riekenberg wrote:
> Vitaliy Margolen wrote:
>> ChangeLog:
>> user: Preserve LastError.

> You can move the ok() for GetLastError() direct after GetKeyNameTextA():
>> +        SetLastError(0xdeadbeef);
>>          len = GetKeyNameTextA(i << 16, buff, sizeof(buff));
>> +        ok( GetLastError() == 0xdeadbeef,
>> +            "%d Wrong LastError = %ld\n", i, GetLastError());
>>          ok(len | !buff[0], "%d: Buffer is not zeroed\n", i);

> Just my 2 ¢
Those 2 ¢ would be spent better looking over wine-devel. What you proposed is
not correct.

Vitaliy







[prev in list] [next in list] [prev in thread] [next in thread]