[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Problems with SpamAssassin
From:       Mike McCormack <mike () codeweavers ! com>
Date:       2004-09-30 7:52:14
Message-ID: 415BBB2E.30903 () codeweavers ! com
[Download RAW message or body]

Raphael is having some trouble sending mail to the lists winehq.org. 
Can we get him whitelisted?

Mike

["Fwd: Mail revenu en erreur / Undelivered Mail Returned to Sender" (message/rfc822)]



----------  Forwarded Message  ----------

Subject: Mail revenu en erreur / Undelivered Mail Returned to Sender
Date: Thursday 30 September 2004 09:30
From: Mail Delivery System <MAILER-DAEMON@club-internet.fr>
To: fenix@club-internet.fr

[Auto-generated bounce from Postfix server on relay-am.club-internet.fr]


####################################################################
# L'ENVOI DE VOTRE MESSAGE A ETE RETARDE.  INUTILE DE LE RENVOYER. #
# THIS IS A WARNING ONLY.  YOU DO NOT NEED TO RESEND YOUR MESSAGE. #
####################################################################

Le message suivant n'a pu etre envoye pendant 0.0 heures, pour la
raison indiquee ci-desssous.  Le serveur va reessayer pendant 5.0
jours.


                   -- Postmaster Club-Internet

  __//__

Your message could not be delivered for 0.0 hours.
It will be retried until it is 5.0 days old.

                   -- Club-Internet Postmaster


----- Message d'erreur / Failure reason --------------------


<julliard@winehq.org>: host mail.winehq.org[198.144.15.226] said: 550 5.7.1
    Blocked by SpamAssassin (in reply to end of DATA command)

-------------------------------------------------------

["Attachment: 1" (message/delivery-status)]

Reporting-MTA: dns; relay-am.club-internet.fr
X-Postfix-Queue-ID: 7DD2025D5E
X-Postfix-Sender: rfc822; fenix@club-internet.fr
Arrival-Date: Thu, 30 Sep 2004 09:30:12 +0200 (CEST)

Final-Recipient: rfc822; julliard@winehq.org
Action: failed
Status: 5.0.0
Diagnostic-Code: X-Postfix; host mail.winehq.org[198.144.15.226] said: 550
    5.7.1 Blocked by SpamAssassin (in reply to end of DATA command)

["Attachment: 2" (message/rfc822)]



Hi Alexandre,

I cannot send my patch to wine-patches ml.
Seems that SpamAssassin don't like it :(

As i have tried a lot and it failed, i send it directly to you

Can you use SpamAssassin "sa-learn" to learn my mails :)

Thx

Regards,
Raphael

 Changelog:
  - Make D3D8 Counters thread safe (Janitorial Task about Interlocked APIs)

----------  Forwarded Message  ----------

Subject: Mail revenu en erreur / Undelivered Mail Returned to Sender
Date: Thursday 30 September 2004 01:41
From: Mail Delivery System <MAILER-DAEMON@club-internet.fr>
To: fenix@club-internet.fr

[Auto-generated bounce from Postfix server on relay-av.club-internet.fr]


####################################################################
# L'ENVOI DE VOTRE MESSAGE A ETE RETARDE.  INUTILE DE LE RENVOYER. #
# THIS IS A WARNING ONLY.  YOU DO NOT NEED TO RESEND YOUR MESSAGE. #
####################################################################

Le message suivant n'a pu etre envoye pendant 0.0 heures, pour la
raison indiquee ci-desssous.  Le serveur va reessayer pendant 5.0
jours.


                   -- Postmaster Club-Internet

  __//__

Your message could not be delivered for 0.0 hours.
It will be retried until it is 5.0 days old.

                   -- Club-Internet Postmaster


----- Message d'erreur / Failure reason --------------------


<wine-patches@winehq.com>: host mail.winehq.com[198.144.15.226] said: 550
 5.7.1 Blocked by SpamAssassin (in reply to end of DATA command)

-------------------------------------------------------

["dx125.diff" (text/plain)]


["dx125.diff" (text/x-diff)]

Index: basetexture.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/basetexture.c,v
retrieving revision 1.13
diff -u -r1.13 basetexture.c
--- basetexture.c	8 Sep 2004 01:50:38 -0000	1.13
+++ basetexture.c	29 Sep 2004 23:02:45 -0000
@@ -52,15 +52,16 @@
 ULONG WINAPI IDirect3DBaseTexture8Impl_AddRef(LPDIRECT3DBASETEXTURE8 iface) {
     IDirect3DBaseTexture8Impl *This = (IDirect3DBaseTexture8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DBaseTexture8Impl_Release(LPDIRECT3DBASETEXTURE8 iface) {
     IDirect3DBaseTexture8Impl *This = (IDirect3DBaseTexture8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
-    if (ref == 0)
+    if (ref == 0) {
         HeapFree(GetProcessHeap(), 0, This);
+    }
     return ref;
 }
 
Index: cubetexture.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/cubetexture.c,v
retrieving revision 1.17
diff -u -r1.17 cubetexture.c
--- cubetexture.c	8 Sep 2004 01:50:38 -0000	1.17
+++ cubetexture.c	29 Sep 2004 23:02:46 -0000
@@ -53,16 +53,15 @@
 ULONG WINAPI IDirect3DCubeTexture8Impl_AddRef(LPDIRECT3DCUBETEXTURE8 iface) {
     IDirect3DCubeTexture8Impl *This = (IDirect3DCubeTexture8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DCubeTexture8Impl_Release(LPDIRECT3DCUBETEXTURE8 iface) {
     IDirect3DCubeTexture8Impl *This = (IDirect3DCubeTexture8Impl *)iface;
-    ULONG ref = --This->ref;
-    unsigned int i, j;
-
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
+        unsigned int i, j;
         for (i = 0; i < This->levels; i++) {
 	  for (j = 0; j < 6; j++) { 
 	    if (This->surfaces[j][i] != NULL) {
Index: device.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/device.c,v
retrieving revision 1.116
diff -u -r1.116 device.c
--- device.c	8 Sep 2004 01:50:38 -0000	1.116
+++ device.c	29 Sep 2004 23:02:51 -0000
@@ -298,12 +298,12 @@
 ULONG WINAPI IDirect3DDevice8Impl_AddRef(LPDIRECT3DDEVICE8 iface) {
     IDirect3DDevice8Impl *This = (IDirect3DDevice8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DDevice8Impl_Release(LPDIRECT3DDEVICE8 iface) {
     IDirect3DDevice8Impl *This = (IDirect3DDevice8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
       IDirect3DDevice8Impl_CleanRender(iface);
Index: directx.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/directx.c,v
retrieving revision 1.78
diff -u -r1.78 directx.c
--- directx.c	29 Sep 2004 21:26:47 -0000	1.78
+++ directx.c	29 Sep 2004 23:02:53 -0000
@@ -147,7 +147,7 @@
      if (ctx.ref > 0) ret = &ctx;
    }
 
-   if (NULL != ret) ++ret->ref;
+   if (NULL != ret) InterlockedIncrement(&ret->ref);
 
    return ret;
 }
@@ -156,8 +156,8 @@
 void WineD3DReleaseFakeGLContext(WineD3D_Context* ctx) {
   /* If we created a dummy context, throw it away */
   if (NULL != ctx) {
-    --ctx->ref;
-    if (0 == ctx->ref) {
+    ULONG ref = InterlockedDecrement(&ctx->ref);
+    if (0 == ref) {
       glXMakeCurrent(ctx->display, None, NULL);
       glXDestroyContext(ctx->display, ctx->glCtx);
       ctx->display = NULL;
@@ -187,12 +187,12 @@
 ULONG WINAPI IDirect3D8Impl_AddRef(LPDIRECT3D8 iface) {
     IDirect3D8Impl *This = (IDirect3D8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3D8Impl_Release(LPDIRECT3D8 iface) {
     IDirect3D8Impl *This = (IDirect3D8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
         IWineD3D_Release(This->WineD3D);
Index: indexbuffer.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/indexbuffer.c,v
retrieving revision 1.10
diff -u -r1.10 indexbuffer.c
--- indexbuffer.c	8 Sep 2004 01:50:38 -0000	1.10
+++ indexbuffer.c	29 Sep 2004 23:02:53 -0000
@@ -52,12 +52,12 @@
 ULONG WINAPI IDirect3DIndexBuffer8Impl_AddRef(LPDIRECT3DINDEXBUFFER8 iface) {
     IDirect3DIndexBuffer8Impl *This = (IDirect3DIndexBuffer8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DIndexBuffer8Impl_Release(LPDIRECT3DINDEXBUFFER8 iface) {
     IDirect3DIndexBuffer8Impl *This = (IDirect3DIndexBuffer8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
         HeapFree(GetProcessHeap(), 0, This->allocatedMemory);
Index: resource.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/resource.c,v
retrieving revision 1.10
diff -u -r1.10 resource.c
--- resource.c	8 Sep 2004 01:50:38 -0000	1.10
+++ resource.c	29 Sep 2004 23:02:53 -0000
@@ -51,15 +51,16 @@
 ULONG WINAPI IDirect3DResource8Impl_AddRef(LPDIRECT3DRESOURCE8 iface) {
     IDirect3DResource8Impl *This = (IDirect3DResource8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DResource8Impl_Release(LPDIRECT3DRESOURCE8 iface) {
     IDirect3DResource8Impl *This = (IDirect3DResource8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
-    if (ref == 0)
-        HeapFree(GetProcessHeap(), 0, This);
+    if (ref == 0) {
+      HeapFree(GetProcessHeap(), 0, This);
+    }
     return ref;
 }
 
Index: surface.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/surface.c,v
retrieving revision 1.39
diff -u -r1.39 surface.c
--- surface.c	8 Sep 2004 01:50:38 -0000	1.39
+++ surface.c	29 Sep 2004 23:02:54 -0000
@@ -56,12 +56,12 @@
 ULONG WINAPI IDirect3DSurface8Impl_AddRef(LPDIRECT3DSURFACE8 iface) {
     IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DSurface8Impl_Release(LPDIRECT3DSURFACE8 iface) {
     IDirect3DSurface8Impl *This = (IDirect3DSurface8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
       HeapFree(GetProcessHeap(), 0, This->allocatedMemory);
Index: swapchain.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/swapchain.c,v
retrieving revision 1.10
diff -u -r1.10 swapchain.c
--- swapchain.c	8 Sep 2004 01:50:38 -0000	1.10
+++ swapchain.c	29 Sep 2004 23:02:54 -0000
@@ -51,12 +51,12 @@
 ULONG WINAPI IDirect3DSwapChain8Impl_AddRef(LPDIRECT3DSWAPCHAIN8 iface) {
     IDirect3DSwapChain8Impl *This = (IDirect3DSwapChain8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DSwapChain8Impl_Release(LPDIRECT3DSWAPCHAIN8 iface) {
     IDirect3DSwapChain8Impl *This = (IDirect3DSwapChain8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
         HeapFree(GetProcessHeap(), 0, This);
Index: texture.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/texture.c,v
retrieving revision 1.18
diff -u -r1.18 texture.c
--- texture.c	8 Sep 2004 01:50:38 -0000	1.18
+++ texture.c	29 Sep 2004 23:02:54 -0000
@@ -53,16 +53,15 @@
 ULONG WINAPI IDirect3DTexture8Impl_AddRef(LPDIRECT3DTEXTURE8 iface) {
     IDirect3DTexture8Impl *This = (IDirect3DTexture8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DTexture8Impl_Release(LPDIRECT3DTEXTURE8 iface) {
     IDirect3DTexture8Impl *This = (IDirect3DTexture8Impl *)iface;
-    ULONG ref = --This->ref;
-    unsigned int i;
-
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
+        unsigned int i;
         for (i = 0; i < This->levels; i++) {
             if (This->surfaces[i] != NULL) {
                 TRACE("(%p) : Releasing surface %p\n", This, This->surfaces[i]);
Index: vertexbuffer.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/vertexbuffer.c,v
retrieving revision 1.8
diff -u -r1.8 vertexbuffer.c
--- vertexbuffer.c	8 Sep 2004 01:50:38 -0000	1.8
+++ vertexbuffer.c	29 Sep 2004 23:02:55 -0000
@@ -52,12 +52,12 @@
 ULONG WINAPI IDirect3DVertexBuffer8Impl_AddRef(LPDIRECT3DVERTEXBUFFER8 iface) {
     IDirect3DVertexBuffer8Impl *This = (IDirect3DVertexBuffer8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DVertexBuffer8Impl_Release(LPDIRECT3DVERTEXBUFFER8 iface) {
     IDirect3DVertexBuffer8Impl *This = (IDirect3DVertexBuffer8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
         if (NULL != This->allocatedMemory) HeapFree(GetProcessHeap(), 0, This->allocatedMemory);
Index: volume.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/volume.c,v
retrieving revision 1.13
diff -u -r1.13 volume.c
--- volume.c	8 Sep 2004 01:50:38 -0000	1.13
+++ volume.c	29 Sep 2004 23:02:55 -0000
@@ -53,12 +53,12 @@
 ULONG WINAPI IDirect3DVolume8Impl_AddRef(LPDIRECT3DVOLUME8 iface) {
     IDirect3DVolume8Impl *This = (IDirect3DVolume8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DVolume8Impl_Release(LPDIRECT3DVOLUME8 iface) {
     IDirect3DVolume8Impl *This = (IDirect3DVolume8Impl *)iface;
-    ULONG ref = --This->ref;
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
         HeapFree(GetProcessHeap(), 0, This->allocatedMemory);
Index: volumetexture.c
===================================================================
RCS file: /home/wine/wine/dlls/d3d8/volumetexture.c,v
retrieving revision 1.17
diff -u -r1.17 volumetexture.c
--- volumetexture.c	8 Sep 2004 01:50:38 -0000	1.17
+++ volumetexture.c	29 Sep 2004 23:02:55 -0000
@@ -54,16 +54,15 @@
 ULONG WINAPI IDirect3DVolumeTexture8Impl_AddRef(LPDIRECT3DVOLUMETEXTURE8 iface) {
     IDirect3DVolumeTexture8Impl *This = (IDirect3DVolumeTexture8Impl *)iface;
     TRACE("(%p) : AddRef from %ld\n", This, This->ref);
-    return ++(This->ref);
+    return InterlockedIncrement(&This->ref);
 }
 
 ULONG WINAPI IDirect3DVolumeTexture8Impl_Release(LPDIRECT3DVOLUMETEXTURE8 iface) {
     IDirect3DVolumeTexture8Impl *This = (IDirect3DVolumeTexture8Impl *)iface;
-    ULONG ref = --This->ref;
-    UINT  i;
-
+    ULONG ref = InterlockedDecrement(&This->ref);
     TRACE("(%p) : ReleaseRef to %ld\n", This, This->ref);
     if (ref == 0) {
+        UINT  i;
         for (i = 0; i < This->levels; i++) {
             if (This->volumes[i] != NULL) {
                 TRACE("(%p) : Releasing volume %p\n", This, This->volumes[i]);


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic