[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Strictify make_authors
From:       Francois Gouget <fgouget () free ! fr>
Date:       2004-09-29 23:50:42
Message-ID: Pine.LNX.4.58.0409300147270.20906 () amboise ! dolphin
[Download RAW message or body]

I'm not very familiar with this tool so all I can say is that it does
not have compilation errors at startup and seems to behave rationally.

Changelog:

 * tools/make_authors

   Switch to 'perl -w' and add 'use strict;'.
   Add prototypes to all functions.


-- 
Francois Gouget         fgouget@free.fr        http://fgouget.free.fr/
                     Avoid the Gates of Hell - use Linux.
["p20040930-make_authors.diff" (TEXT/plain)]

Index: tools/make_authors
===================================================================
RCS file: /var/cvs/wine/tools/make_authors,v
retrieving revision 1.5
diff -u -r1.5 make_authors
--- tools/make_authors	18 Nov 2003 19:50:24 -0000	1.5
+++ tools/make_authors	23 Sep 2004 12:48:07 -0000
@@ -1,4 +1,4 @@
-#! /usr/bin/perl
+#! /usr/bin/perl -w
 #
 # Generate AUTHORS
 #
@@ -18,7 +18,9 @@
 # License along with this library; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 #
+use strict;
 
+my @authors;
 open(AUTHORS,"<AUTHORS") or die "Can't open AUTHORS";
 open(NEWAUTHORS,">AUTHORS.new");
 while(<AUTHORS>)
@@ -33,10 +35,11 @@
   }
 
 # Sort them
-sub cmpnames
+sub cmpnames()
   {
-    @anames = split(" ",$a);
-    @bnames = split(" ",$b);
+    my @anames = split(" ",$a);
+    my @bnames = split(" ",$b);
+    my $ret;
     $ret = $anames[-1] cmp $bnames[-1];
     $ret = $anames[0] cmp $bnames[0] unless $ret;
     return $ret;


[prev in list] [next in list] [prev in thread] [next in thread]