'Re: [webkit-dev] Suggesting to enable paint timing by default'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Suggesting to enable paint timing by default
From:       Maciej Stachowiak <mjs () apple ! com>
Date:       2020-08-20 3:26:33
Message-ID: 350DE8DB-F660-43E9-9A39-046B8BE267F0 () apple ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Jul 17, 2020, at 12:12 AM, Noam Rosenthal <noam@webkit.org> wrote:
> 
> 
> 
> On Thu, Jul 16, 2020 at 11:03 PM Keith Miller <keith_miller@apple.com \
> <mailto:keith_miller@apple.com>> wrote: Results appear to be neutral on the page load time \
> benchmark, so you should be good on that front. I don't know who the best person to vet the \
> maturity of the code is though, sorry. 
> Thanks a lot Keith, I appreciate it!
> @Maciej Stachowiak <mailto:mjs@apple.com>, what would be a good way to assert whether the \
> code maturity is good enough to enable paint timing by default? The original code was \
> reviewed by smfr and initially by zalan. It's covered by over 30 tests, mostly WPT, and A/B \
> tests show no effect on load times as per Keith's check. Would asking for additional reviews \
> be the next step? From whom?

At this point, if a reviewer approves a patch to enable it by default on trunk, I think you are \
good to go.

As a courtesy to Apple, I'd ask you to hold off on landing until mid-September, but that is \
optional.

 - Maciej

[Attachment #5 (unknown)]

<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body \
style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" \
class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul \
17, 2020, at 12:12 AM, Noam Rosenthal &lt;<a href="mailto:noam@webkit.org" \
class="">noam@webkit.org</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div \
class=""><div dir="ltr" class=""><div dir="ltr" class=""><br class=""></div><br class=""><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 16, 2020 at 11:03 PM Keith \
Miller &lt;<a href="mailto:keith_miller@apple.com" class="">keith_miller@apple.com</a>&gt; \
wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: \
break-word;" class="">Results appear to be neutral on the page load time benchmark, so you \
should be good on that front. I don't know who the best person to vet the maturity of the code \
is though, sorry.</div></blockquote><div class=""><br class=""></div><div class="">Thanks a lot \
Keith, I appreciate&nbsp;it!</div><div class=""><a class="gmail_plusreply" id="plusReplyChip-0" \
href="mailto:mjs@apple.com" tabindex="-1">@Maciej Stachowiak</a>, what would be a good way to \
assert whether the code maturity is good enough to enable paint timing by default?<br \
class="">The original code was reviewed by smfr and initially by zalan. It's covered by over 30 \
tests, mostly WPT, and A/B tests show&nbsp;no effect on load times as per Keith's check.<br \
class="">Would asking for additional reviews be the next step? From whom?<br \
class=""></div></div></div></div></blockquote></div><br class=""><div class="">At this point, \
if a reviewer approves a patch to enable it by default on trunk, I think you are good to \
go.</div><div class=""><br class=""></div><div class="">As a courtesy to Apple, I'd ask you to \
hold off on landing until mid-September, but that is optional.</div><div class=""><br \
class=""></div><div class="">&nbsp;- Maciej</div></body></html>

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[prev in list] [next in list] [prev in thread] [next in thread] 