--===============1440654707== Content-type: multipart/alternative; boundary="Apple-Mail=_C7E9DA42-9967-4CC9-894A-86E86E7DCB2B" --Apple-Mail=_C7E9DA42-9967-4CC9-894A-86E86E7DCB2B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 17, 2020, at 12:12 AM, Noam Rosenthal wrote: >=20 >=20 >=20 > On Thu, Jul 16, 2020 at 11:03 PM Keith Miller > wrote: > Results appear to be neutral on the page load time benchmark, so you = should be good on that front. I don=E2=80=99t know who the best person = to vet the maturity of the code is though, sorry. >=20 > Thanks a lot Keith, I appreciate it! > @Maciej Stachowiak , what would be a good way to = assert whether the code maturity is good enough to enable paint timing = by default? > The original code was reviewed by smfr and initially by zalan. It's = covered by over 30 tests, mostly WPT, and A/B tests show no effect on = load times as per Keith's check. > Would asking for additional reviews be the next step? =46rom whom? At this point, if a reviewer approves a patch to enable it by default on = trunk, I think you are good to go. As a courtesy to Apple, I=E2=80=99d ask you to hold off on landing until = mid-September, but that is optional. - Maciej= --Apple-Mail=_C7E9DA42-9967-4CC9-894A-86E86E7DCB2B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jul 17, 2020, at 12:12 AM, Noam Rosenthal <noam@webkit.org> = wrote:



On Thu, Jul 16, 2020 at 11:03 PM Keith = Miller <keith_miller@apple.com> wrote:
Results appear to be neutral on the page load = time benchmark, so you should be good on that front. I don=E2=80=99t = know who the best person to vet the maturity of the code is though, = sorry.

Thanks a lot Keith, I appreciate it!
@Maciej Stachowiak, = what would be a good way to assert whether the code maturity is good = enough to enable paint timing by default?
The original = code was reviewed by smfr and initially by zalan. It's covered by over = 30 tests, mostly WPT, and A/B tests show no effect on load times as = per Keith's check.
Would asking for additional reviews be = the next step? =46rom whom?

At this point, if a reviewer approves a patch to enable it by = default on trunk, I think you are good to go.

As a courtesy to Apple, I=E2=80=99d ask = you to hold off on landing until mid-September, but that is = optional.

 - Maciej
= --Apple-Mail=_C7E9DA42-9967-4CC9-894A-86E86E7DCB2B-- --===============1440654707== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev --===============1440654707==--