[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Suggesting to enable paint timing by default
From:       Noam Rosenthal <noam () webkit ! org>
Date:       2020-07-17 7:12:43
Message-ID: CAGttnEW9DMnRP5jwenuk7FeGUbU07LtY0gCu1zhM+0m1c4xGoA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Jul 16, 2020 at 11:03 PM Keith Miller <keith_miller@apple.com>
wrote:

> Results appear to be neutral on the page load time benchmark, so you
> should be good on that front. I don't know who the best person to vet the
> maturity of the code is though, sorry.
>

Thanks a lot Keith, I appreciate it!
@Maciej Stachowiak <mjs@apple.com>, what would be a good way to assert
whether the code maturity is good enough to enable paint timing by default?
The original code was reviewed by smfr and initially by zalan. It's covered
by over 30 tests, mostly WPT, and A/B tests show no effect on load times as
per Keith's check.
Would asking for additional reviews be the next step? From whom?

Cheers,
Noam

[Attachment #5 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, Jul 16, 2020 at 11:03 PM Keith Miller &lt;<a \
href="mailto:keith_miller@apple.com">keith_miller@apple.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
style="overflow-wrap: break-word;">Results appear to be neutral on the page load time \
benchmark, so you should be good on that front. I don't know who the best person to \
vet the maturity of the code is though, \
sorry.</div></blockquote><div><br></div><div>Thanks a lot Keith, I appreciate  \
it!</div><div><a class="gmail_plusreply" id="plusReplyChip-0" \
href="mailto:mjs@apple.com" tabindex="-1">@Maciej Stachowiak</a>, what would be a \
good way to assert whether the code maturity is good enough to enable paint timing by \
default?<br>The original code was reviewed by smfr and initially by zalan. It&#39;s \
covered by over 30 tests, mostly WPT, and A/B tests show  no effect on load times as \
per Keith&#39;s check.<br>Would asking for additional reviews be the next step? From \
whom?<br><br>Cheers,<br>Noam</div></div></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]