[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Suggesting to enable paint timing by default
From: Keith Miller <keith_miller () apple ! com>
Date: 2020-07-13 18:15:38
Message-ID: 6011021D-8FED-4DF3-B291-AF17804C20A3 () apple ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
If you tell me how to enable paint timing by default, I can start an A/B task for \
you. I'm probably not qualified to review it for code maturity though.
Cheers,
Keith
> On Jul 13, 2020, at 3:02 AM, Noam Rosenthal <noam@webkit.org> wrote:
>
>
>
> On Wed, May 27, 2020 at 12:04 PM Yoav Weiss <yoav@yoav.ws <mailto:yoav@yoav.ws>> \
> wrote: +Ryosuke Niwa <mailto:rniwa@webkit.org> +Alex Christensen \
> <mailto:achristensen@apple.com> who were involved in the spec discussions.
> On Wed, May 27, 2020 at 10:29 AM Noam Rosenthal <noam@webkit.org \
> <mailto:noam@webkit.org>> wrote:
>
> Following up on this.
> FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak <mjs@apple.com \
> <mailto:mjs@apple.com>> wrote:
>
> > On May 11, 2020, at 9:53 PM, Noam Rosenthal <noam@webkit.org \
> > <mailto:noam@webkit.org>> wrote:
> >
> >
> > On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak <mjs@apple.com \
> > <mailto:mjs@apple.com>> wrote:
> > I noticed from comments in one of the Radars that the patch may result in an \
> > additional "fake paint", so it should probably be performance tested. Have you \
> > done any testing? I've tested it locally, I haven't noticed any significant side \
> > effect, because in complex situations the fake paint only happens once per page \
> > and bails early once contentfulness is detected. but I can run any additional \
> > test needed.
> > We'll likely want to A/B some of Apple's page load speed benchmarks.
> > A/B testing load speed sounds sensible. How do we go about doing that?
>
> Unfortunately our page load speed benchmarks are not public because they \
> incorporate captured page content, which we can't freely redistribute.
> So, can someone else from Apple review that the code is mature enough for this? \
> Simon had reviewed the original patch. Maybe Zalan/Darin?
> A helpful person from Apple may be able to set up an A/B test for this patch.
> What's required to ask for help from a helpful person at Apple? :)
> Hola
> Pinging about this again :)
> The code for paint timing API is sitting there in the repo, waiting either for \
> internal Apple A/B tests, for an additional code maturity review, or for enabling \
> it by default... I'm here if any changes in the code need to be made.
> Trying to figure out how we can proceed with this... @Maciej Stachowiak \
> <mailto:mjs@apple.com>? Cheers
> _______________________________________________
> webkit-dev mailing list
> webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org>
> https://lists.webkit.org/mailman/listinfo/webkit-dev \
> <https://lists.webkit.org/mailman/listinfo/webkit-dev>
[Attachment #5 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
line-break: after-white-space;" class="">If you tell me how to enable paint timing by \
default, I can start an A/B task for you. I'm probably not qualified to review it for \
code maturity though.<div class=""><br class=""></div><div class="">Cheers,</div><div \
class="">Keith<br class=""><div><br class=""><blockquote type="cite" class=""><div \
class="">On Jul 13, 2020, at 3:02 AM, Noam Rosenthal <<a \
href="mailto:noam@webkit.org" class="">noam@webkit.org</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><div dir="ltr" style="caret-color: \
rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br \
class="Apple-interchange-newline"><br class=""><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Wed, May 27, 2020 at 12:04 PM Yoav Weiss <<a \
href="mailto:yoav@yoav.ws" class="">yoav@yoav.ws</a>> wrote:<br \
class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; \
border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, \
204); padding-left: 1ex;"><div dir="ltr" class=""><a class="gmail_plusreply" \
id="gmail-m_2187235869986475176plusReplyChip-0" href="mailto:rniwa@webkit.org" \
target="_blank">+Ryosuke Niwa</a> <a class="gmail_plusreply" \
id="gmail-m_2187235869986475176plusReplyChip-1" href="mailto:achristensen@apple.com" \
target="_blank">+Alex Christensen</a> who were involved in the spec \
discussions.<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Wed, May 27, 2020 at 10:29 AM Noam Rosenthal <<a \
href="mailto:noam@webkit.org" target="_blank" class="">noam@webkit.org</a>> \
wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px \
0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, \
204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div dir="ltr" class=""><br \
class=""></div><br class=""><div class="gmail_quote"><div class="">Following up on \
this.</div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; \
border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, \
204); padding-left: 1ex;"><div dir="ltr" class=""><div class="gmail_quote"><div \
class="gmail_attr">FOn Tue, May 12, 2020 at 10:28 AM Maciej Stachowiak <<a \
href="mailto:mjs@apple.com" target="_blank" class="">mjs@apple.com</a>> wrote:<br \
class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; \
border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, \
204); padding-left: 1ex;"><br class=""><div class=""><br class=""><blockquote \
type="cite" class=""><div class="">On May 11, 2020, at 9:53 PM, Noam Rosenthal <<a \
href="mailto:noam@webkit.org" target="_blank" class="">noam@webkit.org</a>> \
wrote:</div><br class=""><div class=""><div dir="ltr" class=""><div dir="ltr" \
class=""><br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Tue, May 12, 2020 at 1:36 AM Maciej Stachowiak <<a \
href="mailto:mjs@apple.com" target="_blank" class="">mjs@apple.com</a>> wrote:<br \
class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; \
border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, \
204); padding-left: 1ex;"><div class=""><div class=""><br class=""></div>I noticed \
from comments in one of the Radars that the patch may result in an additional "fake \
paint", so it should probably be performance tested. Have you done any testing?<span \
class="Apple-converted-space"> </span></div></blockquote><div class="">I've \
tested it locally, I haven't noticed any significant side effect, because in complex \
situations the fake paint only happens once per page and bails early once \
contentfulness is detected. but I can run any additional test needed.<br \
class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px \
0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, \
204, 204); padding-left: 1ex;"><div class="">We'll likely want to A/B some of Apple's \
page load speed benchmarks.</div></blockquote><div class="">A/B testing load speed \
sounds sensible. How do we go about doing that?<br \
class=""></div></div></div></div></blockquote><br class=""></div><div \
class="">Unfortunately our page load speed benchmarks are not public because they \
incorporate captured page content, which we can't freely redistribute.</div><div \
class=""><br class=""></div></blockquote></div></div></blockquote><div class="">So, \
can someone else from Apple review that the code is mature enough for this? Simon had \
reviewed the original patch. Maybe Zalan/Darin? <br class=""><br \
class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; \
border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, \
204); padding-left: 1ex;"><div dir="ltr" class=""><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; \
border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, \
204); padding-left: 1ex;"><div class=""></div><div class="">A helpful person from \
Apple may be able to set up an A/B test for this patch.<br \
class=""></div></blockquote></div></div></blockquote><div class="">What's required to \
ask for help from a helpful person at Apple? \
:) </div></div></div></blockquote></div></blockquote><div class="">Hola<br \
class="">Pinging about this again :)<br class="">The code for paint timing API is \
sitting there in the repo, waiting either for internal Apple A/B tests, for an \
additional code maturity review, or for enabling it by default... I'm here if any \
changes in the code need to be made.<br class=""><br class="">Trying to figure out \
how we can proceed with this... <a class="gmail_plusreply" id="plusReplyChip-1" \
href="mailto:mjs@apple.com" tabindex="-1">@Maciej Stachowiak</a>?<br \
class="">Cheers</div></div></div><span style="caret-color: rgb(0, 0, 0); font-family: \
Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline \
!important;" class="">_______________________________________________</span><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" \
class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none; float: none; display: inline !important;" class="">webkit-dev \
mailing list</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none;" class=""><a href="mailto:webkit-dev@lists.webkit.org" \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px;" class="">webkit-dev@lists.webkit.org</a><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" \
class=""><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" \
style="font-family: Helvetica; font-size: 12px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px;" \
class="">https://lists.webkit.org/mailman/listinfo/webkit-dev</a></div></blockquote></div><br \
class=""></div></body></html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic