[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] Anyone else having these problems with run-webkit-tests?
From: Bem Jones-Bey <bjonesbe () adobe ! com>
Date: 2014-03-26 23:40:20
Message-ID: F4F89DBB-103E-40B8-9D08-A2E86104C2B7 () adobe ! com
[Download RAW message or body]
On Mar 24, 2014, at 15:54 , Dirk Pranke \
<dpranke@chromium.org<mailto:dpranke@chromium.org>> wrote:
On Mon, Mar 24, 2014 at 3:32 PM, Bem Jones-Bey \
<bjonesbe@adobe.com<mailto:bjonesbe@adobe.com>> wrote:
On Mar 24, 2014, at 14:54 , Dirk Pranke \
<dpranke@chromium.org<mailto:dpranke@chromium.org>> wrote:
On Sun, Mar 23, 2014 at 12:52 PM, Benjamin Poulain \
<benjamin@webkit.org<mailto:benjamin@webkit.org>> wrote: Same here :(
On 3/23/14, 12:15 PM, Darin Adler wrote:
When I use run-webkit-tests to run the entire test suite, on a debug build of TOT \
WebKit, on Mavericks, I’m having the following problems:
- Towards the end of the run, the tests run slowly, over a second per test on my \
3.5GHz i7 iMac with tons of memory, which is about 10X too slow I think. The sample \
shows the vast majority of the time is spent in JavaScript garbage collection. This \
is running mostly the svg/custom tests. Yep. The time from 31k to 33k is a long as \
from 0 to 31k :(
- Towards the end of the run, instead of the 8 parallel copies of DumpRenderTree, \
only 1 copy of DumpRenderTree seems to run. This is running mostly the svg/custom \
tests. I think the problem is we can only run DumpRenderTree in parallel on different \
folders. Toward the end, everything left is one or two slow folders.
The problem is partially that the sharding is folder-at-a-time, partially that the \
svg folder is big and slow, and partially that "svg" comes near the end of the \
alphabet (i.e., we don't start the big slow directory until close to the end of run, \
so there ends up being one big long pole).
At some point we added code to run-webkit-tests to have a list of "slow" directories \
that got started towards the beginning. I don't remember if we did that before or \
after the Blink fork, but it would be easy to port it over from Blink if it was \
after.
I'm pretty sure this was after the Blink fork. I did a quick look through the \
history, and I found this:
http://src.chromium.org/viewvc/blink?revision=152697&view=revision
Is that the correct change? If it will make tests run faster in WebKit land as well, \
I'm more than happy to port it myself. :-)
Yup, that's the one. Obviously the whole "virtual test suite" thing is less relevant, \
but you can use it for any directory you want.
Well, I tried that patch, replacing "virtual" with "svg", and it doesn't seem to have \
any effect on the speed of the run for me. But I'm also not 100% sure that I am \
seeing the slowness issue that others are reporting. (I also get 18 copies of DRT, \
not 8, so....)
- Bem
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: \
after-white-space;"> On Mar 24, 2014, at 15:54 , Dirk Pranke <<a \
href="mailto:dpranke@chromium.org">dpranke@chromium.org</a>> wrote:<br> <div><br \
class="Apple-interchange-newline"> <blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Mon, Mar 24, 2014 at 3:32 PM, Bem Jones-Bey <span \
dir="ltr"> <<a href="mailto:bjonesbe@adobe.com" \
target="_blank">bjonesbe@adobe.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div style="word-wrap:break-word">
<div class=""><br>
<div>
<div>On Mar 24, 2014, at 14:54 , Dirk Pranke <<a \
href="mailto:dpranke@chromium.org" target="_blank">dpranke@chromium.org</a>> \
wrote:</div> <br>
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Sun, Mar 23, 2014 at 12:52 PM, Benjamin Poulain <span \
dir="ltr"> <<a href="mailto:benjamin@webkit.org" \
target="_blank">benjamin@webkit.org</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Same here :(
<div><br>
<br>
On 3/23/14, 12:15 PM, Darin Adler wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> When I use run-webkit-tests to run the entire test suite, on \
a debug build of TOT WebKit, on Mavericks, I’m having the following problems:<br> \
<br>
- Towards the end of the run, the tests run slowly, over a second per test on my \
3.5GHz i7 iMac with tons of memory, which is about 10X too slow I think. The sample \
shows the vast majority of the time is spent in JavaScript garbage collection. This \
is running mostly the svg/custom tests.<br>
</blockquote>
</div>
Yep. The time from 31k to 33k is a long as from 0 to 31k :(
<div><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
- Towards the end of the run, instead of the 8 parallel copies of DumpRenderTree, \
only 1 copy of DumpRenderTree seems to run. This is running mostly the svg/custom \
tests.<br> </blockquote>
</div>
I think the problem is we can only run DumpRenderTree in parallel on different \
folders. Toward the end, everything left is one or two slow folders. <div><br>
</div>
</blockquote>
<div><br>
</div>
<div>The problem is partially that the sharding is folder-at-a-time, partially that \
the svg folder is big and slow, and partially that "svg" comes near the end \
of the alphabet (i.e., we don't start the big slow directory until close to the end \
of run, so there ends up being one big long pole).</div>
<div><br>
</div>
<div>At some point we added code to run-webkit-tests to have a list of \
"slow" directories that got started towards the beginning. I don't remember \
if we did that before or after the Blink fork, but it would be easy to port it over \
from Blink if it was after.</div> </div>
</div>
</div>
</blockquote>
<br>
</div>
</div>
<div>I'm pretty sure this was after the Blink fork. I did a quick look through the \
history, and I found this:</div> <div><br>
</div>
<div>
<div><a href="http://src.chromium.org/viewvc/blink?revision=152697&view=revision" \
target="_blank">http://src.chromium.org/viewvc/blink?revision=152697&view=revision</a></div>
<div><br>
</div>
</div>
<div>Is that the correct change? If it will make tests run faster in WebKit land as \
well, I'm more than happy to port it myself. :-)</div> <span class="HOEnZb"><font \
color="#888888"> <div><br>
</div>
</font></span></div>
</blockquote>
<div><br>
</div>
<div>Yup, that's the one. Obviously the whole "virtual test suite" thing is \
less relevant, but you can use it for any directory you want.</div> </div>
</div>
</div>
</blockquote>
<br>
</div>
<div>Well, I tried that patch, replacing "virtual" with "svg", \
and it doesn't seem to have any effect on the speed of the run for me. But I'm also \
not 100% sure that I am seeing the slowness issue that others are reporting. (I also \
get 18 copies of DRT, not 8, so....)</div>
<div><br>
</div>
<div>- Bem</div>
<br>
</body>
</html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
--===============9169601846250251921==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic