[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Reformatting-only patches being applied to trunk
From:       David Levin <levin () google ! com>
Date:       2009-07-26 20:24:19
Message-ID: b902e34a0907261324x5f10f544jb58514268e8c2e17 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sat, Jul 25, 2009 at 4:11 PM, Ojan Vafai <ojan@chromium.org> wrote:
>
> We could also hook [the style checker] into any create-patch scripts so
> that patches [from] (new) contributors upload don't need to be manually
> vetted by a reviewer for style.
>

This could be done without making all code conform because Shinichiro has
done the work to be able to print out lint errors for only the lines that
are being changed in the patch.  (Personally, I think the style checking
tool needs a little baking/dogfood'ing time before this happens.)

dave

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Sat, Jul 25, 2009 at 4:11 PM, Ojan Vafai <span \
dir="ltr">&lt;<a href="mailto:ojan@chromium.org">ojan@chromium.org</a>&gt;</span> \
wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"> <div class="gmail_quote"><div>We could also hook [the style \
checker] into any create-patch scripts so that patches [from] (new) contributors \
upload don&#39;t need to be manually vetted by a reviewer for style.</div>

<div></div></div></blockquote><div><br></div><div>This could be done without making \
all code conform because Shinichiro has done the work to be able to print out lint \
errors for only the lines that are being changed in the patch.  (Personally, I think \
the style checking tool needs a little baking/dogfood&#39;ing time before this \
happens.)</div> <div><br></div><div>dave</div><div> </div><div><br></div></div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]