[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs
From:       Peter Kasting <pkasting () google ! com>
Date:       2009-05-25 6:42:43
Message-ID: d62cf1d10905242342p3c813f21u55a0238420c95d11 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, May 24, 2009 at 11:17 PM, David Hyatt <hyatt@apple.com> wrote:

> Can you cite a particular class as an example?  I don't think we have any
> aversion to using per-port subclasses as long as we aren't incurring a
> vtable cost and as long as that class has no subclasses already.
>

I don't think you do either, which is part of why I said that I think when
this has come up it's been handled quite well.  I think historically most
things have been done using #ifdefs and that that's been changing as there
have been more (and more disparate) ports, which turn out to require a
variety of methods depending on the circumstances.

Perhaps the only complaint I can think of here is that sometimes the fear of
vtables seems (to me) to border on paranoia -- it doesn't hurt if the class
in question is completely off the critical path.  But I think that's a
pretty minor quibble.

PK

[Attachment #5 (text/html)]

<div class="gmail_quote">On Sun, May 24, 2009 at 11:17 PM, David Hyatt <span \
dir="ltr">&lt;<a href="mailto:hyatt@apple.com">hyatt@apple.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="im">Can you cite a particular class as an \
example?  I don&#39;t think we have any aversion to using per-port subclasses as long \
as we aren&#39;t incurring a vtable cost and as long as that class has no subclasses \
already.</div>

</blockquote></div><br><div>I don&#39;t think you do either, which is part of why I \
said that I think when this has come up it&#39;s been handled quite well.  I think \
historically most things have been done using #ifdefs and that that&#39;s been \
changing as there have been more (and more disparate) ports, which turn out to \
require a variety of methods depending on the circumstances.</div> \
<div><br></div><div>Perhaps the only complaint I can think of here is that sometimes \
the fear of vtables seems (to me) to border on paranoia -- it doesn&#39;t hurt if the \
class in question is completely off the critical path.  But I think that&#39;s a \
pretty minor quibble.</div> <div><br></div><div>PK</div>



_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[prev in list] [next in list] [prev in thread] [next in thread]