[prev in list] [next in list] [prev in thread] [next in thread] 

List:       webkit-dev
Subject:    Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs
From:       David Hyatt <hyatt () apple ! com>
Date:       2009-05-25 6:17:26
Message-ID: C0E25D61-AEFD-492C-8D0D-5D205DAD01BC () apple ! com
[Download RAW message or body]


On May 25, 2009, at 12:51 AM, Peter Kasting wrote:

> I would prefer to optimize for reading the code for my port, which  
> generally means as few #ifdefs as possible, and pushing as much  
> logic into the build system as possible (by including or not  
> including various files).  It implies things like preferring per- 
> port subclasses to port-specific members in the parent class,  
> preferring to not include files rather than #ifdef their contents  
> away... basically, the opposite of all the decisions WebKit looks to  
> have taken :D
>

Can you cite a particular class as an example?  I don't think we have  
any aversion to using per-port subclasses as long as we aren't  
incurring a vtable cost and as long as that class has no subclasses  
already.

dave
(hyatt@apple.com)

_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]