[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-dev
Subject: Re: [webkit-dev] [webkit-changes] [38187] trunk/JavaScriptCore
From: George Staikos <staikos () kde ! org>
Date: 2008-11-10 15:59:12
Message-ID: E2C132EC-8C23-4036-81A9-8FC0377A2E3D () kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Shouldn't that be PLATFORM(LINUX) instead of PLATFORM(GTK)? Seems
that PLATFORM(GTK) could be wrong in some cases, and not having, for
example PLATFORM(QT), could be also wrong.
On 7-Nov-08, at 3:47 AM, alp@webkit.org wrote:
> --- trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp 2008-11-06 18:42:24
> UTC (rev 38186)
> +++ trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp 2008-11-06 18:47:44
> UTC (rev 38187)
> @@ -51,6 +51,14 @@
> #include "TCSpinLock.h"
> #include "UnusedParam.h"
>
> +#if HAVE(MMAP)
> +static const int cProtFlags = PROT_READ | PROT_WRITE
> +#if ENABLE(CTI) && PLATFORM(GTK)
> + | PROT_EXEC
> +#endif
> + ;
> +#endif
--
George Staikos
Torch Mobile Inc.
http://www.torchmobile.com/
[Attachment #5 (unknown)]
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; " class=""> <div><br></div>Shouldn't that be \
PLATFORM(LINUX) instead of PLATFORM(GTK)? Seems that PLATFORM(GTK) could be wrong in \
some cases, and not having, for example PLATFORM(QT), could be also wrong.<div><br \
style=""><div style=""><div style="">On 7-Nov-08, at 3:47 AM, <a \
href="mailto:alp@webkit.org">alp@webkit.org</a> wrote:</div><blockquote \
type="cite"><div id="msg" style=""><dl class="meta"><dt><span \
class="Apple-style-span" style="-webkit-text-stroke-width: -1; ">--- \
trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp 2008-11-06 18:42:24 UTC (rev \
38186)</span></dt></dl></div><div id="patch" style=""><div class="modfile" \
style=""><pre class="diff"><span><span class="info">+++ \
trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp 2008-11-06 18:47:44 UTC (rev 38187) \
</span><span class="lines">@@ -51,6 +51,14 @@ </span><span class="cx"> #include \
"TCSpinLock.h" </span><span class="cx"> #include "UnusedParam.h"
</span><span class="cx">
</span><ins>+#if HAVE(MMAP)
+static const int cProtFlags = PROT_READ | PROT_WRITE
+#if ENABLE(CTI) && PLATFORM(GTK)
+ | PROT_EXEC
+#endif
+ ;
+#endif<br style=""></ins></span></pre></div></div></blockquote></div><div> <span \
class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; \
text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; \
widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; \
-webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; \
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; \
"><div>--</div><div><div>George Staikos</div><div>Torch Mobile Inc.</div><div><a \
href="http://www.torchmobile.com">http://www.torchmobile.com</a>/</div></div></span> \
</div><br style=""></div></body></html>
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic