From webkit-dev Mon Nov 10 15:59:12 2008 From: George Staikos Date: Mon, 10 Nov 2008 15:59:12 +0000 To: webkit-dev Subject: Re: [webkit-dev] [webkit-changes] [38187] trunk/JavaScriptCore Message-Id: X-MARC-Message: https://marc.info/?l=webkit-dev&m=122635314907685 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2120199367==" --===============2120199367== Content-Type: multipart/alternative; boundary=Apple-Mail-1-1064933317 --Apple-Mail-1-1064933317 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Shouldn't that be PLATFORM(LINUX) instead of PLATFORM(GTK)? Seems that PLATFORM(GTK) could be wrong in some cases, and not having, for example PLATFORM(QT), could be also wrong. On 7-Nov-08, at 3:47 AM, alp@webkit.org wrote: > --- trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp 2008-11-06 18:42:24 > UTC (rev 38186) > +++ trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp 2008-11-06 18:47:44 > UTC (rev 38187) > @@ -51,6 +51,14 @@ > #include "TCSpinLock.h" > #include "UnusedParam.h" > > +#if HAVE(MMAP) > +static const int cProtFlags = PROT_READ | PROT_WRITE > +#if ENABLE(CTI) && PLATFORM(GTK) > + | PROT_EXEC > +#endif > + ; > +#endif -- George Staikos Torch Mobile Inc. http://www.torchmobile.com/ --Apple-Mail-1-1064933317 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1

Shouldn't that be PLATFORM(LINUX) instead of = PLATFORM(GTK)? =A0Seems that PLATFORM(GTK) could be wrong in some cases, = and not having, for example PLATFORM(QT), could be also wrong.

On 7-Nov-08, at 3:47 AM, alp@webkit.org = wrote:
--- = trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp 2008-11-06 18:42:24 UTC = (rev 38186)
+++ trunk/JavaScriptCore/wtf/TCSystemAlloc.cpp	=
2008-11-06 18:47:44 UTC (rev 38187)
@@ -51,6 +51,14 @@
 #include "TCSpinLock.h"
 #include "UnusedParam.h"
=20
+#if HAVE(MMAP)
+static const int cProtFlags =3D PROT_READ | PROT_WRITE
+#if ENABLE(CTI) && PLATFORM(GTK)
+                              | PROT_EXEC
+#endif
+                              ;
+#endif
--
George = Staikos
Torch Mobile Inc.
<= /div>

= --Apple-Mail-1-1064933317-- --===============2120199367== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev --===============2120199367==--