[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [239504] trunk
From: justin_michaud () apple ! com
Date: 2018-12-21 17:33:15
Message-ID: 20181221173315.2C37110051CE () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[239504] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/239504">239504</a></dd> \
<dt>Author</dt> <dd>justin_michaud@apple.com</dd> <dt>Date</dt> <dd>2018-12-21 \
09:33:14 -0800 (Fri, 21 Dec 2018)</dd> </dl>
<h3>Log Message</h3>
<pre>Repeated background images with zero size should display the background color
https://bugs.webkit.org/show_bug.cgi?id=192962
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/backgrounds/background-repeat-with-zero-size.html
* platform/LengthSize.h:
(WebCore::LengthSize::isEmpty const):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/style/FillLayer.h:
(WebCore::FillLayer::isEmpty const):
LayoutTests:
Fix a rendering bug exposed by the CSS Variable wpt tests where repeated backgrounds \
with zero size not draw the background colour underneath.
* fast/backgrounds/background-repeat-with-zero-size-expected.html: Added.
* fast/backgrounds/background-repeat-with-zero-size.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformLengthSizeh">trunk/Source/WebCore/platform/LengthSize.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxModelObjectcpp">trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleFillLayerh">trunk/Source/WebCore/rendering/style/FillLayer.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatwithzerosizeexpectedhtml" \
>trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size-expected.html</a></li>
>
<li><a href="#trunkLayoutTestsfastbackgroundsbackgroundrepeatwithzerosizehtml">trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (239503 => \
239504)</h4> <pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2018-12-21 16:20:03 UTC (rev \
239503)
+++ trunk/LayoutTests/ChangeLog 2018-12-21 17:33:14 UTC (rev 239504)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2018-12-21 Justin Michaud <justin_michaud@apple.com>
+
+ Repeated background images with zero size should display the background \
color + https://bugs.webkit.org/show_bug.cgi?id=192962
+
+ Reviewed by Antti Koivisto.
+
+ Fix a rendering bug exposed by the CSS Variable wpt tests where repeated \
backgrounds with zero size + not draw the background colour underneath.
+
+ * fast/backgrounds/background-repeat-with-zero-size-expected.html: Added.
+ * fast/backgrounds/background-repeat-with-zero-size.html: Added.
+
</ins><span class="cx"> 2018-12-20 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Show punycode if URL contains Latin small letter \
dotless i </span></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatwithzerosizeexpectedhtml"></a>
<div class="addfile"><h4>Added: \
trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size-expected.html (0 \
=> 239504)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size-expected.html \
(rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size-expected.html 2018-12-21 \
17:33:14 UTC (rev 239504) </span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<style>
+.el {
+ width: 150px;
+ height: 150px;
+ background-color: green;
+}
+</style>
+
+<div class="el el1">
+</div>
+
+<div class="el el2" >
+</div>
+
+<div class="el el3" style="position: relative;">
+<div style="background: red; width: 10px; height: 10px; position: absolute; \
top: 0; left: 0;"></div> +</div>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastbackgroundsbackgroundrepeatwithzerosizehtml"></a>
<div class="addfile"><h4>Added: \
trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size.html (0 => \
239504)</h4> <pre class="diff"><span>
<span class="info">--- \
trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size.html \
(rev 0)
+++ trunk/LayoutTests/fast/backgrounds/background-repeat-with-zero-size.html 2018-12-21 \
17:33:14 UTC (rev 239504) </span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+<style>
+.el {
+ width: 150px;
+ height: 150px;
+ background-color: green;
+ background-image: linear-gradient(red,red);
+ background-size: 0 0;
+}
+
+.el1 {
+ background-repeat: repeat;
+}
+
+.el2 {
+ background-repeat: no-repeat;
+}
+
+.el3 {
+ background-repeat: no-repeat;
+ background-size: 10px 10px;
+}
+</style>
+
+<div class="el el1">
+</div>
+
+<div class="el el2">
+</div>
+
+<div class="el el3">
+</div>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (239503 => \
239504)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2018-12-21 16:20:03 UTC (rev \
239503)
+++ trunk/Source/WebCore/ChangeLog 2018-12-21 17:33:14 UTC (rev 239504)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2018-12-21 Justin Michaud <justin_michaud@apple.com>
+
+ Repeated background images with zero size should display the background \
color + https://bugs.webkit.org/show_bug.cgi?id=192962
+
+ Reviewed by Antti Koivisto.
+
+ Test: fast/backgrounds/background-repeat-with-zero-size.html
+
+ * platform/LengthSize.h:
+ (WebCore::LengthSize::isEmpty const):
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintFillLayerExtended):
+ * rendering/style/FillLayer.h:
+ (WebCore::FillLayer::isEmpty const):
+
</ins><span class="cx"> 2018-12-21 Manuel Rego Casasnovas <rego@igalia.com>
</span><span class="cx">
</span><span class="cx"> [css-grid] Fix percentages in relative offsets for \
grid items </span></span></pre></div>
<a id="trunkSourceWebCoreplatformLengthSizeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/LengthSize.h (239503 \
=> 239504)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/LengthSize.h 2018-12-21 16:20:03 \
UTC (rev 239503)
+++ trunk/Source/WebCore/platform/LengthSize.h 2018-12-21 17:33:14 UTC (rev 239504)
</span><span class="lines">@@ -26,6 +26,8 @@
</span><span class="cx"> struct LengthSize {
</span><span class="cx"> Length width;
</span><span class="cx"> Length height;
</span><ins>+
+ bool isEmpty() const { return width.isZero() || height.isZero(); }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> ALWAYS_INLINE bool operator==(const LengthSize& a, const \
LengthSize& b) </span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxModelObjectcpp"></a>
<div class="modfile"><h4>Modified: \
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (239503 => 239504)</h4> <pre \
class="diff"><span> <span class="info">--- \
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2018-12-21 16:20:03 UTC (rev \
239503)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2018-12-21 17:33:14 UTC \
(rev 239504) </span><span class="lines">@@ -950,7 +950,7 @@
</span><span class="cx"> if (!bgLayer.next()) {
</span><span class="cx"> LayoutRect backgroundRect(scrolledPaintRect);
</span><span class="cx"> bool boxShadowShouldBeAppliedToBackground = \
this->boxShadowShouldBeAppliedToBackground(rect.location(), bleedAvoidance, box); \
</span><del>- if (boxShadowShouldBeAppliedToBackground || \
!shouldPaintBackgroundImage || !bgLayer.hasOpaqueImage(*this) || \
!bgLayer.hasRepeatXY()) { </del><ins>+ if \
(boxShadowShouldBeAppliedToBackground || !shouldPaintBackgroundImage || \
!bgLayer.hasOpaqueImage(*this) || !bgLayer.hasRepeatXY() || bgLayer.isEmpty()) { \
</ins><span class="cx"> if (!boxShadowShouldBeAppliedToBackground) \
</span><span class="cx"> backgroundRect.intersect(paintInfo.rect); \
</span><span class="cx"> </span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleFillLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/FillLayer.h \
(239503 => 239504)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/FillLayer.h 2018-12-21 \
16:20:03 UTC (rev 239503)
+++ trunk/Source/WebCore/rendering/style/FillLayer.h 2018-12-21 17:33:14 UTC (rev \
239504) </span><span class="lines">@@ -101,6 +101,8 @@
</span><span class="cx"> bool isSizeSet() const { return \
static_cast<FillSizeType>(m_sizeType) != FillSizeType::None; } </span><span \
class="cx"> bool isMaskSourceTypeSet() const { return m_maskSourceTypeSet; } \
</span><span class="cx"> </span><ins>+ bool isEmpty() const { return (sizeType() \
== FillSizeType::Size && m_sizeLength.isEmpty()) || sizeType() == \
FillSizeType::None; } +
</ins><span class="cx"> void setImage(RefPtr<StyleImage>&& image) { \
m_image = WTFMove(image); m_imageSet = true; } </span><span class="cx"> void \
setXPosition(Length length) { m_xPosition = WTFMove(length); m_xPosSet = true; } \
</span><span class="cx"> void setYPosition(Length length) { m_yPosition = \
WTFMove(length); m_yPosSet = true; } </span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic