[prev in list] [next in list] [prev in thread] [next in thread]
List: webkit-changes
Subject: [webkit-changes] [239503] trunk
From: bfulgham () apple ! com
Date: 2018-12-21 16:20:03
Message-ID: 20181221162003.89CE710051CE () svn ! webkit ! org
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[239503] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://trac.webkit.org/projects/webkit/changeset/239503">239503</a></dd> \
<dt>Author</dt> <dd>bfulgham@apple.com</dd> <dt>Date</dt> <dd>2018-12-21 08:20:03 \
-0800 (Fri, 21 Dec 2018)</dd> </dl>
<h3>Log Message</h3>
<pre>Show punycode if URL contains Latin small letter dotless i
https://bugs.webkit.org/show_bug.cgi?id=192944
<rdar://problem/46103047>
Reviewed by Andy Estes.
Source/WTF:
Revise our "lookalike character" logic to include the small Latin
dotless i character.
Test: fast/url/host.html
* wtf/cocoa/NSURLExtras.mm:
(WTF::isLookalikeCharacter):
LayoutTests:
* fast/url/host-expected.txt:
* fast/url/host.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasturlhostexpectedtxt">trunk/LayoutTests/fast/url/host-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasturlhosthtml">trunk/LayoutTests/fast/url/host.html</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfcocoaNSURLExtrasmm">trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (239502 => \
239503)</h4> <pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2018-12-21 12:29:57 UTC (rev \
239502)
+++ trunk/LayoutTests/ChangeLog 2018-12-21 16:20:03 UTC (rev 239503)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2018-12-20 Brent Fulgham <bfulgham@apple.com>
+
+ Show punycode if URL contains Latin small letter dotless i
+ https://bugs.webkit.org/show_bug.cgi?id=192944
+ <rdar://problem/46103047>
+
+ Reviewed by Andy Estes.
+
+ * fast/url/host-expected.txt:
+ * fast/url/host.html:
+
</ins><span class="cx"> 2018-12-21 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed GTK+ gardening. Remove platform specific \
files that are exactly the same as the generic expectation. \
</span></span></pre></div> <a id="trunkLayoutTestsfasturlhostexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/url/host-expected.txt \
(239502 => 239503)</h4> <pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/url/host-expected.txt 2018-12-21 \
12:29:57 UTC (rev 239502)
+++ trunk/LayoutTests/fast/url/host-expected.txt 2018-12-21 16:20:03 UTC (rev 239503)
</span><span class="lines">@@ -49,6 +49,8 @@
</span><span class="cx"> PASS canonicalize('http://quip−apple.com/') is \
'http://xn--quipapple-tf4e.com/' </span><span class="cx"> PASS \
canonicalize('http://iclouꝱ.com/') is 'http://xn--iclou-rl3s.com/' </span><span \
class="cx"> PASS canonicalize('http://gọọgle.com/') is \
'http://xn--ggle-gx5aa.com/' </span><ins>+PASS canonicalize('http://ıcloud.com/') is \
'http://xn--cloud-m4a.com/' +PASS canonicalize('http://twıtter.com/') is \
'http://xn--twtter-q9a.com/' </ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsfasturlhosthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/url/host.html (239502 => \
239503)</h4> <pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/url/host.html 2018-12-21 12:29:57 UTC \
(rev 239502)
+++ trunk/LayoutTests/fast/url/host.html 2018-12-21 16:20:03 UTC (rev 239503)
</span><span class="lines">@@ -89,7 +89,9 @@
</span><span class="cx"> ["quip\u2011apple.com", \
"xn--quipapple-y79d.com"], </span><span class="cx"> \
["quip\u2212apple.com", "xn--quipapple-tf4e.com"], </span><span \
class="cx"> ["iclou\uA771.com", "xn--iclou-rl3s.com"], \
</span><del>- ["g\u1ECD\u1ECDgle.com", "xn--ggle-gx5aa.com"] \
</del><ins>+ ["g\u1ECD\u1ECDgle.com", "xn--ggle-gx5aa.com"], + \
["\u0131cloud.com", "xn--cloud-m4a.com"], + \
["tw\u0131tter.com", "xn--twtter-q9a.com"] </ins><span \
class="cx"> ]; </span><span class="cx">
</span><span class="cx"> for (var i = 0; i < cases.length; ++i) {
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (239502 => 239503)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2018-12-21 12:29:57 UTC (rev \
239502)
+++ trunk/Source/WTF/ChangeLog 2018-12-21 16:20:03 UTC (rev 239503)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2018-12-20 Brent Fulgham <bfulgham@apple.com>
+
+ Show punycode if URL contains Latin small letter dotless i
+ https://bugs.webkit.org/show_bug.cgi?id=192944
+ <rdar://problem/46103047>
+
+ Reviewed by Andy Estes.
+
+ Revise our "lookalike character" logic to include the small Latin
+ dotless i character.
+
+ Test: fast/url/host.html
+
+ * wtf/cocoa/NSURLExtras.mm:
+ (WTF::isLookalikeCharacter):
+
</ins><span class="cx"> 2018-12-20 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Use Optional::hasValue() instead of \
Optional::has_value() </span></span></pre></div>
<a id="trunkSourceWTFwtfcocoaNSURLExtrasmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm (239502 \
=> 239503)</h4> <pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm 2018-12-21 12:29:57 \
UTC (rev 239502)
+++ trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm 2018-12-21 16:20:03 UTC (rev 239503)
</span><span class="lines">@@ -115,6 +115,7 @@
</span><span class="cx"> case 0x00BD: /* VULGAR FRACTION ONE HALF */
</span><span class="cx"> case 0x00BE: /* VULGAR FRACTION THREE QUARTERS */
</span><span class="cx"> case 0x00ED: /* LATIN SMALL LETTER I WITH ACUTE */
</span><ins>+ case 0x0131: /* LATIN SMALL LETTER DOTLESS I */
</ins><span class="cx"> case 0x01C3: /* LATIN LETTER RETROFLEX CLICK */
</span><span class="cx"> case 0x0251: /* LATIN SMALL LETTER ALPHA */
</span><span class="cx"> case 0x0261: /* LATIN SMALL LETTER SCRIPT G */
</span></span></pre>
</div>
</div>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic