[prev in list] [next in list] [prev in thread] [next in thread] 

List:       velocity-dev
Subject:    Re: Patch
From:       "Llewellyn Falco" <isidore () setgame ! com>
Date:       2005-09-23 4:14:38
Message-ID: 001101c5bff5$508a49a0$0a01a8c0 () lfalco
[Download RAW message or body]

ok,

    you can reproduce all the bug by running the attached tests without the 
patches
    (as is the point of unit tests)


    The patches fix them, most of them are in the order of 1 line, so easier 
to see the code rather than explain.

    the only issue i saw that related was.

    velocity-381

    again each test is pretty straight forward about what it is testing.

    llewellyn.

----- Original Message ----- 
From: "Will Glass-Husain" <wglass@forio.com>
To: "Velocity Developers List" <velocity-dev@jakarta.apache.org>; "Llewellyn 
Falco" <isidore@setgame.com>
Sent: Thursday, September 22, 2005 10:29 AM
Subject: Re: Patch


> Can you please create a JIRA issue then?
>
> Please list exactly the problem you were experiencing, including how to 
> reproduce it.  Then attach the patch and state how it solves the problem.
>
> Really appreciate your contribution - I don't mean to throw up unnecessary 
> obstacles.  But it makes a big difference in ease of tracking to have 
> every change tracked and submitted through our issue tracker.  Among other 
> benefits, it documents the change for those who experience the same bug in 
> an earlier version, and it provides a place for other developers (e.g. me) 
> to ask questions and offer suggestions for improving the specific patch. 
> (and the list serv does not always include all attached files).
>
> Thanks again, WILL
>
> ----- Original Message ----- 
> From: "Llewellyn Falco" <isidore@setgame.com>
> To: "Velocity Developers List" <velocity-dev@jakarta.apache.org>
> Sent: Thursday, September 22, 2005 10:11 AM
> Subject: Re: Patch
>
>
>>I don't know if there are any jira issue's involved.
>>
>> It solves the issues of i was experiencing of..
>>
>> null not being able to pass to uberspect to resolve, as is indecated by 
>> the uberspect implementation and api.
>>
>> info not being correctly created for a failure in a method call.
>>
>> if an object is not null, but the toString returns null the silent 
>> failed.
>>
>>
>> the ant tests passed.
>>
>>    Llewellyn.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-dev-help@jakarta.apache.org 


---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]