[prev in list] [next in list] [prev in thread] [next in thread] 

List:       tcpdump-workers
Subject:    Re: [tcpdump-workers] [PATCH 2/2] print-olsr: Add basic IPv6 support.
From:       Guy Harris <guy () alum ! mit ! edu>
Date:       2009-05-21 17:42:45
Message-ID: 52121840-F675-41A3-ADFC-1D4B5569B2B2 () alum ! mit ! edu
[Download RAW message or body]


On May 16, 2009, at 3:05 PM, Florian Forster wrote:

> From: Florian Forster <octo@leeloo.lan.home.verplant.org>
>
> Unfortunately OLSR uses the same IDs for IPv4 and IPv6 packets, even
> though the size of "messages" differ. The version of the internet  
> protocol
> is therefore handed to the "olsr_print" function.
>
> The code isn't very nice, due to a high density of #ifdef INET6'es. If
> IPv6-support really should be optional, I'm afraid this is inevitable.
> Both, compilation with and without IPv6 support has been tested.
>
> The patch addresses fixes other issues, too. The length given in the  
> packet
> was used for pointer arithmetic without checking if the value was in a
> reasonable range first in several places. It should now be possible to
> decode more than one "namespace message" within a single packet. Other
> changes remove trailing whitespace or fix lines indented with tabs  
> (the
> majority of the file is indented using spaces).

Checked in and pushed.
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.
[prev in list] [next in list] [prev in thread] [next in thread]