[prev in list] [next in list] [prev in thread] [next in thread]
List: taglib-devel
Subject: =?utf-8?Q?Re:_CHAP_frames_support?=
From: Lukáš_Krejčí <krejclu6 () fel ! cvut ! cz>
Date: 2013-04-20 15:42:20
Message-ID: 20130420155315.194BEB37CF6 () postbox ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
[Attachment #4 (text/plain)]
Thanks for help. I started work on ChapterFrame and TableOfContentsFrame classes, but \
I'm not sure about how should I handle embedded frames. According to \
http://id3.org/id3v2-chapters-1.0, CHAP and CTOC frames optionally contain embedded \
frames (like TIT2 or TIT3), which describe content of chapter or provide additional \
material such as URLs and images. How should I handle these embedded frames correctly \
according to taglib style? Should ChapterFrame class contain members that are \
instances of embedded frames corresponding classes (like TextIndetificationFrame), or \
should ChapterFrame class contain strings? Or should I simply ignore these optional \
embedded frames?
Best regards,
Lukas Krejci
Od: Lukáš Lalinský
Odesláno: pondělí, 15. dubna 2013 9:18
Komu: taglib-devel@kde.org
Hi Lukas,
This seems to be just two additional ID3 frames, so that shouldn't be
too hard to implement.
The main implementation of the two frames should go to do the
taglib/mpeg/id3v2/frames/ directory. There should be also some tests
in tests/test_id3v2.cpp for parsing and rendering of the frame data.
When you have the frame reading code implemented, you just need to add
them to mpeg/id3v2/id3v2framefactory.cpp and I think that should be
it.
The best way to submit the patch is a pull request at GitHub (so you
fork the repository at GitHub, create a new branch locally, work on
that branch, push the branch to your fork, submit a pull request
against the master branch).
Lukas
On Sun, Apr 14, 2013 at 9:50 AM, Lukáš Krejčí <krejclu6@fel.cvut.cz> wrote:
> Also, because I'm new to taglib, I would appreciate any help. And by the
> way, how can I submit patch, when I'll finish it? Thanks for answers.
>
> Best regards,
> Lukas Krejci
>
> Od: Lukáš Krejčí
> Odesláno: sobota, 13. dubna 2013 23:08
> Komu: taglib-devel@kde.org
>
> Hi, I'd like to contribute on taglib by adding support for chapter frames
> (https://github.com/taglib/taglib/issues/81). Is it possible?
>
> Best regards,
> Lukas Krejci
>
>
> _______________________________________________
> taglib-devel mailing list
> taglib-devel@kde.org
> https://mail.kde.org/mailman/listinfo/taglib-devel
>
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel
[Attachment #5 (text/html)]
<html><head><style data-externalstyle="true"><!--
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph {
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
}
p.MsoListParagraphCxSpFirst, li.MsoListParagraphCxSpFirst, \
div.MsoListParagraphCxSpFirst, p.MsoListParagraphCxSpMiddle, \
li.MsoListParagraphCxSpMiddle, div.MsoListParagraphCxSpMiddle, \
p.MsoListParagraphCxSpLast, li.MsoListParagraphCxSpLast, div.MsoListParagraphCxSpLast \
{ margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
line-height:115%;
}
--></style></head><body><div data-externalstyle="false" dir="ltr" \
style="font-family:Calibri,'Segoe UI',Meiryo,'Microsoft YaHei UI','Microsoft JhengHei \
UI','Malgun Gothic','Khmer UI','Nirmala UI',Tunga,'Lao \
UI',Ebrima,sans-serif;font-size:12pt;"><div>Thanks for help. I started work on \
ChapterFrame and TableOfContentsFrame classes, but I'm not sure about how should I \
handle embedded frames. According to <a title="http://id3.org/id3v2-chapters-1.0" \
href="http://id3.org/id3v2-chapters-1.0" \
target="_parent">http://id3.org/id3v2-chapters-1.0</a>, CHAP and CTOC frames \
optionally contain embedded frames (like TIT2 or TIT3), which describe content of \
chapter or provide additional material such as URLs and images. How should I handle \
these embedded frames correctly according to taglib style? Should ChapterFrame class \
contain members that are instances of embedded frames corresponding classes \
(like TextIndetificationFrame), or should ChapterFrame class contain strings? Or \
should I simply ignore these optional embedded \
frames?</div><div> </div><div>Best regards,</div><div>Lukas Krejci</div><div \
data-signatureblock="true"> </div><div style="padding-top: 5px; \
border-top-color: rgb(229, 229, 229); border-top-width: 1px; border-top-style: \
solid;"><div><font face="Calibri, 'Segoe UI', Meiryo, 'Microsoft YaHei UI', \
'Microsoft JhengHei UI', 'Malgun Gothic', 'Khmer UI', 'Nirmala UI', Tunga, 'Lao UI', \
Ebrima, sans-serif" style='line-height: 15pt; letter-spacing: 0.02em; font-family: \
Calibri, "Segoe UI", Meiryo, "Microsoft YaHei UI", "Microsoft JhengHei UI", "Malgun \
Gothic", "Khmer UI", "Nirmala UI", Tunga, "Lao UI", Ebrima, sans-serif; font-size: \
11pt;'><b>Od:</b> Lukáš Lalinský<br><b>Odesláno:</b> pondělí, \
15. dubna 2013 \
9:18<br><b>Komu:</b> taglib-devel@kde.org</font></div></div><div> </div>Hi \
Lukas,<br><br>This seems to be just two additional ID3 frames, so that shouldn't \
be<br>too hard to implement.<br><br>The main implementation of the two frames should \
go to do the<br>taglib/mpeg/id3v2/frames/ directory. There should be also some \
tests<br>in tests/test_id3v2.cpp for parsing and rendering of the frame \
data.<br><br>When you have the frame reading code implemented, you just need to \
add<br>them to mpeg/id3v2/id3v2framefactory.cpp and I think that should \
be<br>it.<br><br>The best way to submit the patch is a pull request at GitHub (so \
you<br>fork the repository at GitHub, create a new branch locally, work on<br>that \
branch, push the branch to your fork, submit a pull request<br>against the master \
branch).<br><br>Lukas<br><br>On Sun, Apr 14, 2013 at 9:50 AM, Lukáš Krejčí \
<krejclu6@fel.cvut.cz> wrote:<br>> Also, because I'm new to taglib, I would \
appreciate any help. And by the<br>> way, how can I submit patch, when I'll finish \
it? Thanks for answers.<br>><br>> Best regards,<br>> Lukas \
Krejci<br>><br>> Od: Lukáš Krejčí<br>> Odesláno: sobota, 13. dubna 2013 \
23:08<br>> Komu: taglib-devel@kde.org<br>><br>> Hi, I'd like to contribute \
on taglib by adding support for chapter frames<br>> \
(https://github.com/taglib/taglib/issues/81). Is it possible?<br>><br>> Best \
regards,<br>> Lukas Krejci<br>><br>><br>> \
_______________________________________________<br>> taglib-devel mailing \
list<br>> taglib-devel@kde.org<br>> \
https://mail.kde.org/mailman/listinfo/taglib-devel<br>><br>_______________________________________________<br>taglib-devel \
mailing list<br>taglib-devel@kde.org<br>https://mail.kde.org/mailman/listinfo/taglib-devel<br></div></body></html>
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic