[prev in list] [next in list] [prev in thread] [next in thread] 

List:       taglib-devel
Subject:    Re: mp3 header check bug
From:       Luká¹ Lalinský <lalinsky () gmail ! com>
Date:       2013-04-15 7:48:14
Message-ID: CAGUtLj_1vLaOoFBowNugZLqG7EseNpNRi2RP75wAupth67LO9g () mail ! gmail ! com
[Download RAW message or body]

I've looked it up and you are right, the second byte can be 0xFF, so
I've removed the check:

https://github.com/taglib/taglib/commit/4a85e1e1ca4af7c4453b59b2985702df96660f42

Lukas

On Mon, Apr 15, 2013 at 9:29 AM, Lukáš Lalinský <lalinsky@gmail.com> wrote:
> I'm not very familiar with the MPEG stream format myself, so it's hard
> to review this change for me.
>
> Could you please add some reference for this change?
>
> Lukas
>
> On Tue, Mar 5, 2013 at 9:02 AM, Jingmin Wei <weijingmin.cn@gmail.com> wrote:
>> Hi All,
>>
>> I found some mp3 length returned with bad value, so I have checked the
>> source code. I found something could be wrong with function
>>  bool MPEG::File::secondSynchByte(char byte) .
>>
>> In this case "the mp3 is MPEG1 Layer1 no CRC"  the second byte could be FF.
>> So I modify the file as the diff.
>>
>> Thanks
>>
>> Jeffrey
>>
>> _______________________________________________
>> taglib-devel mailing list
>> taglib-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/taglib-devel
>>
_______________________________________________
taglib-devel mailing list
taglib-devel@kde.org
https://mail.kde.org/mailman/listinfo/taglib-devel

[prev in list] [next in list] [prev in thread] [next in thread]