[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sylpheed
Subject:    [sylpheed:22934] Re: Crash during message body search
From:       Alfons Hoogervorst <alfons () proteus ! demon ! nl>
Date:       2004-05-25 18:05:07
Message-ID: 20040525200507.257e386a () proteus ! demon ! nl
[Download RAW message or body]

Lo James,

On 25-05-04 (Tue) 12:01 -0400 James F.  Hranicky wrote: 

| One of my users is getting a crash during a body search of messages in
| a folder via IMAP:
| 
| #0  gtk_stext_update_text (editable=0xfffffff9, start_pos=0,
| end_pos=0) at gtkstext.c:5577 5577          if
| (CACHE_DATA(cache).start.index < end_pos)(gdb) p cache
| $1 = (GList *) 0x0

Ah, the horrible GtkText.

| 
| Should this loop:
| 
| ----------
|   for (; pixels < height; cache = cache->next)
|     {
|       if (CACHE_DATA(cache).start.index < end_pos)
| ----------
| 
| be changed to this:
| 
| ----------
|   for (; pixels < height && cache; cache = cache->next)
|     {
|       if (CACHE_DATA(cache).start.index < end_pos)
| ----------
| 
| ?

Yeah, that should be safe. Patch?


| 
| I can do more testing if need be.

Do you have any message that we can use to reproduce the crasher?

Bye.


-- 
Ecuación algebraico sin solución posible,
a menos de poseer profundos conocimientos
en matemática - Revueltas (Ocho Por Radio)


[prev in list] [next in list] [prev in thread] [next in thread]