[prev in list] [next in list] [prev in thread] [next in thread] 

List:       sylpheed
Subject:    [sylpheed:11986] Re: Reply to List patch
From:       Alfons Hoogervorst <alfons () proteus ! demon ! nl>
Date:       2002-03-28 17:19:16
[Download RAW message or body]

On Thu, 2002-03-28 at 15:40, Jamin W.Collins wrote:


    All feedback is welcome.



    +	for (i=7; i <= 17; i++) {


Make these the constants you defined earlier in the source. Otherwise it
looks fine.


+		for (i = 0; i < sizeof(mail_list_magic) / 
+				sizeof (mail_list_magic[0]); i++) {


Also it's really "sizeof object" as opposed to "sizeof(type)". Go check
our bible (K&R). ;-)

Bye.


-- 
Ecuación algebraico sin solución posible,
a menos de poseer profundos conocimientos
en matemática - Revueltas (Ocho Por Radio)

[Attachment #3 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
  <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
  <META NAME="GENERATOR" CONTENT="GtkHTML/1.0.1.99">
</HEAD>
<BODY>
On Thu, 2002-03-28 at 15:40, Jamin W.Collins wrote:
<BR>
<FONT SIZE="3"></FONT>
    <BLOCKQUOTE>
<PRE><FONT COLOR="#737373"><FONT SIZE="3"><I>All feedback is welcome.</FONT></FONT></I></PRE>
    </BLOCKQUOTE>
<FONT SIZE="3"></FONT>
    <BLOCKQUOTE>
<PRE><FONT SIZE="3">+	for (i=7; i &lt;= 17; i++) {</FONT></PRE>
    </BLOCKQUOTE>
<FONT SIZE="3"></FONT>
<BR>
<FONT SIZE="3">Make these the constants you defined earlier in the source. Otherwise it looks \
fine.</FONT> <BR>
<FONT SIZE="3"></FONT>
<PRE><FONT SIZE="3">+		for (i = 0; i &lt; sizeof(mail_list_magic) / </FONT>
<FONT SIZE="3">+				sizeof (mail_list_magic[0]); i++) {</FONT>
<FONT SIZE="3"></FONT></PRE>
<FONT SIZE="3">Also it's really &quot;sizeof object&quot; as opposed to &quot;sizeof(type)&quot;. Go \
check our bible (K&amp;R). ;-)</FONT> <BR>
<FONT SIZE="3"></FONT>
<BR>
<FONT SIZE="3">Bye.</FONT>
<BR>
<FONT SIZE="3"></FONT>
<BR>
<FONT SIZE="3"></FONT>
<TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
<PRE>-- 
Ecuaci&#243;n algebraico sin soluci&#243;n posible,
a menos de poseer profundos conocimientos
en matem&#225;tica - Revueltas (Ocho Por Radio)</PRE>
</TD>
</TR>
</TABLE>

</BODY>
</HTML>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic