[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-issues
Subject:    [Issue 4484] New - Factor out the dump stream writer in svnadmin dump, svnrdump dump, svndumpfilter
From:       julianfoad () tigris ! org
Date:       2014-03-25 10:21:43
Message-ID: iz4484 () subversion ! tigris ! org
[Download RAW message or body]

http://subversion.tigris.org/issues/show_bug.cgi?id=4484
                 Issue #|4484
                 Summary|Factor out the dump stream writer in svnadmin dump, sv
                        |nrdump dump, svndumpfilter
               Component|subversion
                 Version|trunk
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|TASK
                Priority|P3
            Subcomponent|libsvn_repos
             Assigned to|issues@subversion
             Reported by|julianfoad






------- Additional comments from julianfoad@tigris.org Tue Mar 25 03:21:43 -0700 2014 -------
Presently, dump stream writing is implemented separately in svnadmin dump,
svnrdump dump, and svndumpfilter. This will surely lead to inconsistencies, if
it hasn't already, and a maintenance burden.

For reading, we have a shared dump stream parser, svn_repos_parse_dumpstream3(),
which translates a dump stream to 'svn_repos_parse_fns3_t' vtable calls. We
should also have a shared dump stream writer, using the same vtable. It should
be provided by libsvn_repos and used by 'svnadmin dump', 'svnrdump dump', and
'svndumpfilter'.

We should then factor out an svn_delta_editor_t to svn_repos_parse_fns3_t
converter from both 'svnadmin dump' and 'svnrdump dump'. We would re-write the
filtering logic of 'svndumpfilter' as a vtable-to-vtable filter between the
parser and the writer.

As well as the obvious benefits such as code re-usability and consistency,
another benefit of this refactoring is that it would be possible to write
round-trip tests of the form (dump stream -> vtable -> dump stream) and (vtable
-> dump stream -> vtable).

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=463&dsMessageId=3075181

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@subversion.tigris.org].
[prev in list] [next in list] [prev in thread] [next in thread]