[prev in list] [next in list] [prev in thread] [next in thread] 

List:       subversion-issues
Subject:    [Issue 4483] New - De-duplicate mergeinfo processing code in svnadmin load, svnrdump load, svndumpfi
From:       julianfoad () tigris ! org
Date:       2014-03-25 9:37:22
Message-ID: iz4483 () subversion ! tigris ! org
[Download RAW message or body]

http://subversion.tigris.org/issues/show_bug.cgi?id=4483
                 Issue #|4483
                 Summary|De-duplicate mergeinfo processing code in svnadmin loa
                        |d, svnrdump load, svndumpfilter
               Component|subversion
                 Version|trunk
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|TASK
                Priority|P3
            Subcomponent|libsvn_repos
             Assigned to|issues@subversion
             Reported by|julianfoad






------- Additional comments from julianfoad@tigris.org Tue Mar 25 02:37:22 -0700 2014 -------
'svnadmin load' and 'svnrdump load' both process mergeinfo in the same ways:
normalizing the EOL style, renumbering revisions, and prefixing source paths,
while 'svndumpfilter' does renumbering of revisions and filtering of source
paths. This code is currently almost identical in libsvn_repos/load-fs-vtable.c
and svnrdump/load_editor.c ('FIXME' comments exist from the time of this
duplication), and the renumbering part is very similar in
svndumpfilter/svndumpfilter.c.

The implementations of this mergeinfo processing code should be de-duplicated.

The way to do this, I think, is to factor it out as one or more
'svn_repos_parse_fns3_t' filters. These would be provided by libsvn_repos and
used by the three 'clients', just as the dump stream parser currently is.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=463&dsMessageId=3075179

To unsubscribe from this discussion, e-mail: [issues-unsubscribe@subversion.tigris.org].
[prev in list] [next in list] [prev in thread] [next in thread]