[prev in list] [next in list] [prev in thread] [next in thread] 

List:       squid-dev
Subject:    Re: [squid-users] Downgrade from 3.0stable10 to 3.0stable9
From:       Henrik Nordstrom <henrik () henriknordstrom ! net>
Date:       2008-11-29 21:02:02
Message-ID: 1227992522.11917.49.camel () localhost ! localdomain
[Download RAW message or body]


lör 2008-11-29 klockan 01:40 +1300 skrev Amos Jeffries:

> Question then to the more informed, is it better to make StoreIOBuffer 
> accept a ssize_t or revert the patch?

Generally size_t should be used. ssize_t only exists to support return
values <0 as errors..

> The reason for having it in the first place was that only one of a few 
> places in the code were doing a subtraction of two values then checking 
> for negatives. The rest were doing a subtraction and assuming that it 
> was always >= 0.

I think those few should cast the result to ssize_t, or be rewritten to
check for b < a instead of a - b < 0

Regards
Henrik

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]