[prev in list] [next in list] [prev in thread] [next in thread] 

List:       rtir
Subject:    Re: [Rtir] ScriptedAction not sending mail
From:       Ruslan Zakirov <ruz () bestpractical ! com>
Date:       2010-07-16 21:33:24
Message-ID: AANLkTinx7GnNHLtHpNTkK13X95_SggLHdgHCzNa0anLP () mail ! gmail ! com
[Download RAW message or body]

Hello Gorazd,

I think $addr should be added as requestor only on investigation. Do
you agree here? Actually, the address is added, but late for auto
reply and on create notifications.

Probably the following patch is more apropriate, could you please test it?

diff --git a/html/RTIR/Tools/ScriptedAction.html
b/html/RTIR/Tools/ScriptedAction.html
index 191c176..2e702cd 100644
--- a/html/RTIR/Tools/ScriptedAction.html
+++ b/html/RTIR/Tools/ScriptedAction.html
@@ -364,6 +364,7 @@ if ( $ARGS{'SubmitAction'} ) {
             %ARGS,
             Queue          => $investigationq->Id,
             'new-MemberOf' => $Incident->Id,
+            Requestor      => $addr,
         );
         unless ( $Ticket ) {
             Abort("Couldn't launch an Investigation");
@@ -373,11 +374,6 @@ if ( $ARGS{'SubmitAction'} ) {
         }
         push @finalresults, @ChildActions;

-        my @watchresults = ProcessTicketWatchers(
-            TicketObj => $Ticket,
-            ARGSRef => { %ARGS, AddRequestor => $addr },
-        );
-
         my $TemplateObj = RT::Template->new( $session{'CurrentUser'} );
         if ( $ARGS{'Template'} ) {
             $TemplateObj->Load( $ARGS{'Template'} );
@@ -424,7 +420,7 @@ if ( $ARGS{'SubmitAction'} ) {
         }

         push @finalresults, map { loc("Ticket [_1]: [_2]", $Ticket->Id, $_) }
-            @watchresults, @updateresults;
+            @updateresults;

         # delete attachments only after they've been sent to everyone
         delete $session{'Attachments'};


2010/7/16 Gorazd Božič <gorazd.bozic@arnes.si>:
> Sure! :-)
>
> --- /opt/src/RT-IR-2.4.3/html/RTIR/Tools/ScriptedAction.html    2009-08-18 17:26:46.000000000 +0200
> +++ local/plugins/RT-IR/html/RTIR/Tools/ScriptedAction.html     2010-07-15 13:38:14.000000000 +0200
> @@ -31,7 +31,6 @@
>  <& /Elements/ListActions, actions => \@finalresults &>
>
>  <form method="get" action="ScriptedAction.html" name="ScriptedAction" enctype="multipart/form-data">
> -<input type="hidden" name="incidentid" value="<%$incidentid%>" />
>  <input type="hidden" name="loop" value="<%$ARGS{'loop'}%>" />
>  <input type="hidden" name="UpdateType" value="response" />
>  <input type="hidden" name="Action" value="Respond" />
> @@ -132,6 +131,14 @@
>     <input name="TemplateArg" size="60" value="<% $ARGS{'TemplateArg'} %>" />
>   </td>
>  </tr>
> +<tr>
> +  <td class="label">
> +    <&|/l&>Link to incident</&>:
> +  </td>
> +  <td>
> +    <input type="text" name="incidentid" value="<%$incidentid%>" />
> +  </td>
> +</tr>
>   <tr>
>     <td align="right" colspan="2">
>     </td>
> @@ -313,6 +320,7 @@
>
>         $ARGS{'Subject'} = $original_subject;
>         $ARGS{'Content'} = $original_content;
> +       $ARGS{'Requestors'} = $addr;
>
>         for (qw/Subject Content/) {
>             $ARGS{$_} =~ s/_ADDR_/$addr/g;
>
> _______________________________________________
> Rtir mailing list
> Rtir@lists.bestpractical.com
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rtir
>



-- 
Best regards, Ruslan.
_______________________________________________
Rtir mailing list
Rtir@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rtir

[prev in list] [next in list] [prev in thread] [next in thread]