[prev in list] [next in list] [prev in thread] [next in thread]
List: quanta-devel
Subject: Re: [quanta-devel] Review Request 104595: Actually use ExecuteBrowserPlugin in XDebugJob
From: "Kevin Funk" <krf () gmx ! de>
Date: 2013-02-10 22:56:10
Message-ID: 20130210225610.5788.647 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104595/#review27154
-----------------------------------------------------------
Bump. What's the status here?
- Kevin Funk
On April 13, 2012, 11:29 p.m., Dominik Schmidt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104595/
> -----------------------------------------------------------
>
> (Updated April 13, 2012, 11:29 p.m.)
>
>
> Review request for KDevelop and Quanta.
>
>
> Description
> -------
>
> Currently the XDebugJob always uses QDesktopServices::openUrl() to open the debug \
> page in the browser, this patch makes use of the ExecuteBrowserPlugin instance that \
> is already present in XDebug job so the configured browser is launched.
> Also it makes BrowserAppJob launch the external browser KProc with .startDetached() \
> instead of .execute() to prevent freezing of the KDevelop GUI.
>
> Arguments are currently ignored still, a patch for that is following
>
> Feel free to nitpick, I haven't done any KDE coding in a while and would like to \
> hear any suggestion for improvements :-)
>
> Diffs
> -----
>
> debuggers/xdebug/debugjob.h 9925733
> debuggers/xdebug/debugjob.cpp 0f04914
> plugins/executebrowser/browserappjob.h 37ff700
> plugins/executebrowser/browserappjob.cpp a211205
> plugins/executebrowser/executebrowserplugin.h 7c78733
> plugins/executebrowser/executebrowserplugin.cpp 921142f
> plugins/executebrowser/iexecutebrowserplugin.h f786622
>
> Diff: http://git.reviewboard.kde.org/r/104595/diff/
>
>
> Testing
> -------
>
> It works ... ;-)
>
>
> Thanks,
>
> Dominik Schmidt
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104595/">http://git.reviewboard.kde.org/r/104595/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bump. What's the \
status here?</pre> <br />
<p>- Kevin</p>
<br />
<p>On April 13th, 2012, 11:29 p.m. UTC, Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated April 13, 2012, 11:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the XDebugJob always uses QDesktopServices::openUrl() to open \
the debug page in the browser, this patch makes use of the ExecuteBrowserPlugin \
instance that is already present in XDebug job so the configured browser is launched.
Also it makes BrowserAppJob launch the external browser KProc with .startDetached() \
instead of .execute() to prevent freezing of the KDevelop GUI.
Arguments are currently ignored still, a patch for that is following
Feel free to nitpick, I haven't done any KDE coding in a while and would like to \
hear any suggestion for improvements :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works ... ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/xdebug/debugjob.h <span style="color: grey">(9925733)</span></li>
<li>debuggers/xdebug/debugjob.cpp <span style="color: grey">(0f04914)</span></li>
<li>plugins/executebrowser/browserappjob.h <span style="color: \
grey">(37ff700)</span></li>
<li>plugins/executebrowser/browserappjob.cpp <span style="color: \
grey">(a211205)</span></li>
<li>plugins/executebrowser/executebrowserplugin.h <span style="color: \
grey">(7c78733)</span></li>
<li>plugins/executebrowser/executebrowserplugin.cpp <span style="color: \
grey">(921142f)</span></li>
<li>plugins/executebrowser/iexecutebrowserplugin.h <span style="color: \
grey">(f786622)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104595/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic