--===============7587345397976394326== Content-Type: multipart/alternative; boundary="===============6723278416370103479==" --===============6723278416370103479== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104595/#review27154 ----------------------------------------------------------- Bump. What's the status here? - Kevin Funk On April 13, 2012, 11:29 p.m., Dominik Schmidt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104595/ > ----------------------------------------------------------- > > (Updated April 13, 2012, 11:29 p.m.) > > > Review request for KDevelop and Quanta. > > > Description > ------- > > Currently the XDebugJob always uses QDesktopServices::openUrl() to open the debug page in the browser, this patch makes use of the ExecuteBrowserPlugin instance that is already present in XDebug job so the configured browser is launched. > > Also it makes BrowserAppJob launch the external browser KProc with .startDetached() instead of .execute() to prevent freezing of the KDevelop GUI. > > > Arguments are currently ignored still, a patch for that is following > > Feel free to nitpick, I haven't done any KDE coding in a while and would like to hear any suggestion for improvements :-) > > > Diffs > ----- > > debuggers/xdebug/debugjob.h 9925733 > debuggers/xdebug/debugjob.cpp 0f04914 > plugins/executebrowser/browserappjob.h 37ff700 > plugins/executebrowser/browserappjob.cpp a211205 > plugins/executebrowser/executebrowserplugin.h 7c78733 > plugins/executebrowser/executebrowserplugin.cpp 921142f > plugins/executebrowser/iexecutebrowserplugin.h f786622 > > Diff: http://git.reviewboard.kde.org/r/104595/diff/ > > > Testing > ------- > > It works ... ;-) > > > Thanks, > > Dominik Schmidt > > --===============6723278416370103479== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104595/ 

Bump. What's the status here?

- Kevin


On April 13th, 2012, 11:29 p.m. UTC, Dominik Schmidt wrote:

Review request for KDevelop and Quanta.
By Dominik Schmidt.

Updated April 13, 2012, 11:29 p.m.

Description 

Currently the XDebugJob always uses QDesktopServices::openUrl() to open the debug page in the browser, this patch makes use of the ExecuteBrowserPlugin instance that is already present in XDebug job so the configured browser is launched.

Also it makes BrowserAppJob launch the external browser KProc with .startDetached() instead of .execute() to prevent freezing of the KDevelop GUI.


Arguments are currently ignored still, a patch for that is following

Feel free to nitpick, I haven't done any KDE coding in a while and would like to hear any suggestion for improvements :-)

Testing 

It works ... ;-)

Diffs

  • debuggers/xdebug/debugjob.h (9925733)
  • debuggers/xdebug/debugjob.cpp (0f04914)
  • plugins/executebrowser/browserappjob.h (37ff700)
  • plugins/executebrowser/browserappjob.cpp (a211205)
  • plugins/executebrowser/executebrowserplugin.h (7c78733)
  • plugins/executebrowser/executebrowserplugin.cpp (921142f)
  • plugins/executebrowser/iexecutebrowserplugin.h (f786622)

View Diff
--===============6723278416370103479==-- --===============7587345397976394326== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ quanta-devel mailing list quanta-devel@kde.org https://mail.kde.org/mailman/listinfo/quanta-devel --===============7587345397976394326==--