[prev in list] [next in list] [prev in thread] [next in thread]
List: quanta-devel
Subject: Re: [quanta-devel] Review Request: Actually use ExecuteBrowserPlugin in XDebugJob
From: "Niko Sams" <niko.sams () gmail ! com>
Date: 2012-05-01 17:34:42
Message-ID: 20120501173442.32082.87886 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104595/#review13232
-----------------------------------------------------------
looks good, but please adapt to moved repositories. (now kdev-xdebug and kd=
ev-executebrowser repositories)
plugins/executebrowser/browserappjob.cpp
<http://git.reviewboard.kde.org/r/104595/#comment10355>
makes absolutely sense, but please commit separately.
plugins/executebrowser/iexecutebrowserplugin.h
<http://git.reviewboard.kde.org/r/104595/#comment10354>
hm, I don't like this overriding of url, the url is *the* thing of the =
launch - and you can override it.
=
what about a QMap<QString, QString> queryItems parameter? (or just QStr=
ing?)
- Niko Sams
On April 13, 2012, 11:29 p.m., Dominik Schmidt wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104595/
> -----------------------------------------------------------
> =
> (Updated April 13, 2012, 11:29 p.m.)
> =
> =
> Review request for KDevelop and Quanta.
> =
> =
> Description
> -------
> =
> Currently the XDebugJob always uses QDesktopServices::openUrl() to open t=
he debug page in the browser, this patch makes use of the ExecuteBrowserPlu=
gin instance that is already present in XDebug job so the configured browse=
r is launched.
> =
> Also it makes BrowserAppJob launch the external browser KProc with .start=
Detached() instead of .execute() to prevent freezing of the KDevelop GUI.
> =
> =
> Arguments are currently ignored still, a patch for that is following
> =
> Feel free to nitpick, I haven't done any KDE coding in a while and would =
like to hear any suggestion for improvements :-)
> =
> =
> Diffs
> -----
> =
> debuggers/xdebug/debugjob.h 9925733 =
> debuggers/xdebug/debugjob.cpp 0f04914 =
> plugins/executebrowser/browserappjob.h 37ff700 =
> plugins/executebrowser/browserappjob.cpp a211205 =
> plugins/executebrowser/executebrowserplugin.h 7c78733 =
> plugins/executebrowser/executebrowserplugin.cpp 921142f =
> plugins/executebrowser/iexecutebrowserplugin.h f786622 =
> =
> Diff: http://git.reviewboard.kde.org/r/104595/diff/
> =
> =
> Testing
> -------
> =
> It works ... ;-)
> =
> =
> Thanks,
> =
> Dominik Schmidt
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104595/">http://git.reviewboard.kde.org/r/104595/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, but please \
adapt to moved repositories. (now kdev-xdebug and kdev-executebrowser \
repositories)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104595/diff/1/?file=56598#file56598line77" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/executebrowser/browserappjob.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
BrowserAppJob::start()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">77</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">proc</span><span class="p">.</span><span class="n"><span \
class="hl">execute</span></span><span class="p">();</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">77</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">proc</span><span class="p">.</span><span class="n"><span \
class="hl">startDetached</span></span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">makes \
absolutely sense, but please commit separately.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104595/diff/1/?file=56601#file56601line52" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/executebrowser/iexecutebrowserplugin.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// second param overrides the url set in the launch configuration, e.g. \
with additional parameters</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hm, I \
don't like this overriding of url, the url is *the* thing of the launch - and you \
can override it.
what about a QMap<QString, QString> queryItems parameter? (or just \
QString?)</pre> </div>
<br />
<p>- Niko</p>
<br />
<p>On April 13th, 2012, 11:29 p.m., Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated April 13, 2012, 11:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the XDebugJob always uses QDesktopServices::openUrl() to open \
the debug page in the browser, this patch makes use of the ExecuteBrowserPlugin \
instance that is already present in XDebug job so the configured browser is launched.
Also it makes BrowserAppJob launch the external browser KProc with .startDetached() \
instead of .execute() to prevent freezing of the KDevelop GUI.
Arguments are currently ignored still, a patch for that is following
Feel free to nitpick, I haven't done any KDE coding in a while and would like to \
hear any suggestion for improvements :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works ... ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/xdebug/debugjob.h <span style="color: grey">(9925733)</span></li>
<li>debuggers/xdebug/debugjob.cpp <span style="color: grey">(0f04914)</span></li>
<li>plugins/executebrowser/browserappjob.h <span style="color: \
grey">(37ff700)</span></li>
<li>plugins/executebrowser/browserappjob.cpp <span style="color: \
grey">(a211205)</span></li>
<li>plugins/executebrowser/executebrowserplugin.h <span style="color: \
grey">(7c78733)</span></li>
<li>plugins/executebrowser/executebrowserplugin.cpp <span style="color: \
grey">(921142f)</span></li>
<li>plugins/executebrowser/iexecutebrowserplugin.h <span style="color: \
grey">(f786622)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104595/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic