--===============3158227313133978711== Content-Type: multipart/alternative; boundary="===============7973993768848871083==" --===============7973993768848871083== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104595/#review13232 ----------------------------------------------------------- looks good, but please adapt to moved repositories. (now kdev-xdebug and kd= ev-executebrowser repositories) plugins/executebrowser/browserappjob.cpp makes absolutely sense, but please commit separately. plugins/executebrowser/iexecutebrowserplugin.h hm, I don't like this overriding of url, the url is *the* thing of the = launch - and you can override it. = what about a QMap queryItems parameter? (or just QStr= ing?) - Niko Sams On April 13, 2012, 11:29 p.m., Dominik Schmidt wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104595/ > ----------------------------------------------------------- > = > (Updated April 13, 2012, 11:29 p.m.) > = > = > Review request for KDevelop and Quanta. > = > = > Description > ------- > = > Currently the XDebugJob always uses QDesktopServices::openUrl() to open t= he debug page in the browser, this patch makes use of the ExecuteBrowserPlu= gin instance that is already present in XDebug job so the configured browse= r is launched. > = > Also it makes BrowserAppJob launch the external browser KProc with .start= Detached() instead of .execute() to prevent freezing of the KDevelop GUI. > = > = > Arguments are currently ignored still, a patch for that is following > = > Feel free to nitpick, I haven't done any KDE coding in a while and would = like to hear any suggestion for improvements :-) > = > = > Diffs > ----- > = > debuggers/xdebug/debugjob.h 9925733 = > debuggers/xdebug/debugjob.cpp 0f04914 = > plugins/executebrowser/browserappjob.h 37ff700 = > plugins/executebrowser/browserappjob.cpp a211205 = > plugins/executebrowser/executebrowserplugin.h 7c78733 = > plugins/executebrowser/executebrowserplugin.cpp 921142f = > plugins/executebrowser/iexecutebrowserplugin.h f786622 = > = > Diff: http://git.reviewboard.kde.org/r/104595/diff/ > = > = > Testing > ------- > = > It works ... ;-) > = > = > Thanks, > = > Dominik Schmidt > = > --===============7973993768848871083== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104595/

looks good=
, but please adapt to moved repositories. (now kdev-xdebug and kdev-execute=
browser repositories)

= =

plugins/executebrowser/browserappjob.cpp (Diff revision 1)
void BrowserAppJob::start()
77	proc.execute();	77	proc.startDetached();

makes absolutely sense, but please commit separately.

= =

plugins/executebrowser/iexecutebrowserplugin.h (Diff revision 1)
public:
		51	// second param overrid= es the url set in the launch configuration, e.g. with additional parameters=

hm, I don't like this overriding of url, the url is *the* thing =
of the launch - and you can override it.

what about a QMap<QString, QString> queryItems parameter? (or just QS=
tring?)

- Niko

On April 13th, 2012, 11:29 p.m., Dominik Schmidt wrote:

Review request for KDevelop and Quanta.

By Dominik Schmidt.

Updated April 13, 2012, 11:29 p.m.

Descripti= on

Currently the XDebugJob always uses QDesktopServices::openUr=
l() to open the debug page in the browser, this patch makes use of the Exec=
uteBrowserPlugin instance that is already present in XDebug job so the conf=
igured browser is launched.

Also it makes BrowserAppJob launch the external browser KProc with .startDe=
tached() instead of .execute() to prevent freezing of the KDevelop GUI.


Arguments are currently ignored still, a patch for that is following

Feel free to nitpick, I haven't done any KDE coding in a while and woul=
d like to hear any suggestion for improvements :-)

Testing <= /h1>

It works ... ;-)

Diffs=

debuggers/xdebug/debugjob.h (9925733)
debuggers/xdebug/debugjob.cpp (0f04914)
plugins/executebrowser/browserappjob.h (37= ff700)
plugins/executebrowser/browserappjob.cpp (= a211205)
plugins/executebrowser/executebrowserplugin.h (7c78733)
plugins/executebrowser/executebrowserplugin.cpp (921142f)
plugins/executebrowser/iexecutebrowserplugin.h (f786622)

--===============7973993768848871083==-- --===============3158227313133978711== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ quanta-devel mailing list quanta-devel@kde.org https://mail.kde.org/mailman/listinfo/quanta-devel --===============3158227313133978711==--