[prev in list] [next in list] [prev in thread] [next in thread]
List: quanta-devel
Subject: Re: [quanta-devel] Review Request: Fix compiling of quanta master
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-23 23:26:07
Message-ID: 20111223232607.21120.96646 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103386/#review9225
-----------------------------------------------------------
This review has been submitted with commit 98ee7f47fc416555d4bb854428776c17=
fec2d802 by Florian Zumkeller-Quast to branch master.
- Commit Hook
On Dec. 23, 2011, 10:07 p.m., Florian Zumkeller-Quast wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103386/
> -----------------------------------------------------------
> =
> (Updated Dec. 23, 2011, 10:07 p.m.)
> =
> =
> Review request for KDevelop and Quanta.
> =
> =
> Description
> -------
> =
> Since the last changes of ISourceFormatter from KDevPlatform Quanta was b=
roken and did not compile.
> This patch fixes the compiling issues by changing phpformatterplugin and =
xmlformatterplugin to the new interface of ISourceFormatter.
> =
> During the testing it looked to me that there are two different options s=
toring the indentation value for a formatter:
> "INDENT" and "indent_size". Because only the latter contained a non-zero =
value, i changed the behaviour to use the latter one.
> =
> =
> Diffs
> -----
> =
> languages/xml/formatter/formatterplugin.h dbe183a =
> languages/xml/formatter/formatterplugin.cpp 4e62a1e =
> plugins/phpformatter/formatterplugin.h 6dc7028 =
> plugins/phpformatter/formatterplugin.cpp f1ca6fd =
> =
> Diff: http://git.reviewboard.kde.org/r/103386/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Florian Zumkeller-Quast
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103386/">http://git.reviewboard.kde.org/r/103386/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 98ee7f47fc416555d4bb854428776c17fec2d802 by Florian \
Zumkeller-Quast to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 23rd, 2011, 10:07 p.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2011, 10:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since the last changes of ISourceFormatter from KDevPlatform Quanta was \
broken and did not compile. This patch fixes the compiling issues by changing \
phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter.
During the testing it looked to me that there are two different options storing the \
indentation value for a formatter: "INDENT" and "indent_size". \
Because only the latter contained a non-zero value, i changed the behaviour to use \
the latter one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style="color: \
grey">(dbe183a)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style="color: \
grey">(4e62a1e)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style="color: \
grey">(6dc7028)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style="color: \
grey">(f1ca6fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103386/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic