This review has been submitted with commit 98ee7f47fc416555d4bb854428776c17fec2d802 by Florian Zumkeller-Quast to branch master.
- Commit
On December 23rd, 2011, 10:07 p.m., Florian Zumkeller-Quast wrote:
|
Review request for KDevelop and Quanta.
By Florian Zumkeller-Quast.
Updated Dec. 23, 2011, 10:07 p.m.
Description
Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile.
This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter.
During the testing it looked to me that there are two different options storing the indentation value for a formatter:
"INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.
|
Diffs
- languages/xml/formatter/formatterplugin.h (dbe183a)
- languages/xml/formatter/formatterplugin.cpp (4e62a1e)
- plugins/phpformatter/formatterplugin.h (6dc7028)
- plugins/phpformatter/formatterplugin.cpp (f1ca6fd)
View Diff
|