'[quanta-devel] Review Request: Fix compile break of quanta'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quanta-devel
Subject:    [quanta-devel] Review Request: Fix compile break of quanta
From:       "Florian Zumkeller-Quast" <branleb () googlemail ! com>
Date:       2011-11-10 12:05:26
Message-ID: 20111110120526.28594.16851 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103106/
-----------------------------------------------------------

Review request for KDevelop and Quanta.

Description
-------

Some changes on the Interface of ISourceFormatter from the kdevplatform pro=
ject broke compiling of quanta.
This Patch fixes the interface of the SourceFormatter derived classes and s=
ome calls to these methods with the new KUrl parameter inserted.

Diffs
-----

  languages/xml/formatter/formatterplugin.h e8799f1 =

  languages/xml/formatter/formatterplugin.cpp 4b04725 =

  languages/xml/formatter/sgmlformatter.cpp 4a99d79 =

  languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f =

  plugins/phpformatter/formatterplugin.h 8b462bc =

  plugins/phpformatter/formatterplugin.cpp 761d635 =

Diff: http://git.reviewboard.kde.org/r/103106/diff/diff

Testing
-------

Quanta compiles fine with that patch.

Thanks,

Florian Zumkeller-Quast

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103106/">http://git.reviewboard.kde.org/r/103106/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some changes on the Interface of ISourceFormatter from the kdevplatform \
project broke compiling of quanta. This Patch fixes the interface of the \
SourceFormatter derived classes and some calls to these methods with the new KUrl \
parameter inserted.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Quanta compiles fine with that patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>languages/xml/formatter/formatterplugin.h <span style="color: \
grey">(e8799f1)</span></li>

 <li>languages/xml/formatter/formatterplugin.cpp <span style="color: \
grey">(4b04725)</span></li>

 <li>languages/xml/formatter/sgmlformatter.cpp <span style="color: \
grey">(4a99d79)</span></li>

 <li>languages/xml/language/completion/sgmlcodecompletionmodel.cpp <span \
style="color: grey">(803760f)</span></li>

 <li>plugins/phpformatter/formatterplugin.h <span style="color: \
grey">(8b462bc)</span></li>

 <li>plugins/phpformatter/formatterplugin.cpp <span style="color: \
grey">(761d635)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103106/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

[prev in list] [next in list] [prev in thread] [next in thread] 