[prev in list] [next in list] [prev in thread] [next in thread]
List: quanta-devel
Subject: Re: [quanta-devel] Review Request: Fix compile break of quanta
From: "Milian Wolff" <mail () milianw ! de>
Date: 2011-11-10 14:18:22
Message-ID: 20111110141822.3870.96355 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103106/#review8100
-----------------------------------------------------------
Ship it!
commit is fine besides a few style issues, put the &,* always adjacent to t=
he typename for consistency please.
if you have commit rights, please fix this before pushing.
otherwise send me this patch as created by "git format-patch" - if possible=
with the style issue fixed. otherwise I'll do that.
thanks =
languages/xml/formatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6962>
please put the & adjacent to the typename for consistency
languages/xml/formatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6963>
also here, & adjacent to the typename please
plugins/phpformatter/formatterplugin.h
<http://git.reviewboard.kde.org/r/103106/#comment6964>
again, please & adjacent to typename
plugins/phpformatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6965>
& again... :)
plugins/phpformatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6966>
& again... :)
- Milian Wolff
On Nov. 10, 2011, 12:05 p.m., Florian Zumkeller-Quast wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103106/
> -----------------------------------------------------------
> =
> (Updated Nov. 10, 2011, 12:05 p.m.)
> =
> =
> Review request for KDevelop and Quanta.
> =
> =
> Description
> -------
> =
> Some changes on the Interface of ISourceFormatter from the kdevplatform p=
roject broke compiling of quanta.
> This Patch fixes the interface of the SourceFormatter derived classes and=
some calls to these methods with the new KUrl parameter inserted.
> =
> =
> Diffs
> -----
> =
> languages/xml/formatter/formatterplugin.h e8799f1 =
> languages/xml/formatter/formatterplugin.cpp 4b04725 =
> languages/xml/formatter/sgmlformatter.cpp 4a99d79 =
> languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f =
> plugins/phpformatter/formatterplugin.h 8b462bc =
> plugins/phpformatter/formatterplugin.cpp 761d635 =
> =
> Diff: http://git.reviewboard.kde.org/r/103106/diff/diff
> =
> =
> Testing
> -------
> =
> Quanta compiles fine with that patch.
> =
> =
> Thanks,
> =
> Florian Zumkeller-Quast
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103106/">http://git.reviewboard.kde.org/r/103106/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">commit is fine besides a \
few style issues, put the &,* always adjacent to the typename for consistency \
please.
if you have commit rights, please fix this before pushing.
otherwise send me this patch as created by "git format-patch" - if possible \
with the style issue fixed. otherwise I'll do that.
thanks </pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103106/diff/1/?file=40786#file40786line162" \
style="color: black; font-weight: bold; text-decoration: \
underline;">languages/xml/formatter/formatterplugin.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString FormatterPlugin::highlightModeForMime ( const KMimeType::Ptr &mime ) \
{</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">162</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> \
<span class="n">FormatterPlugin</span><span class="o">::</span><span \
class="n">formatSource</span> <span class="p"><span class="hl">(</span></span><span \
class="hl"> </span><span class="k">const</span> <span class="n">QString</span><span \
class="o"><span class="hl">&</span></span><span class="hl"> </span><span \
class="n">text</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">KMimeType</span><span class="o">::</span><span class="n">Ptr</span><span \
class="o"><span class="hl">&</span></span><span class="hl"> </span><span \
class="n">mime</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">leftContext</span><span class="p">,</span> <span class="k">const</span> \
<span class="n">QString</span><span class="o">&</span> <span \
class="n">rightContext</span> <span class="p"><span class="hl">)</span></span><span \
class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">162</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">QString</span> <span class="n">FormatterPlugin</span><span \
class="o">::</span><span class="n">formatSource</span><span class="p"><span \
class="hl">(</span></span><span class="k">const</span> <span class="n">QString</span> \
<span class="o"><span class="hl">&</span></span><span class="n">text</span><span \
class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="k"><span class="hl">const</span></span><span class="hl"> </span><span \
class="n"><span class="hl">KUrl</span></span><span class="o"><span \
class="hl">&</span></span><span class="hl"> </span><span class="n"><span \
class="hl">url</span></span><span class="p">,</span> <span class="k">const</span> \
<span class="n">KMimeType</span><span class="o">::</span><span class="n">Ptr</span> \
<span class="o"><span class="hl">&</span></span><span class="n">mime</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">leftContext</span><span class="hl"> \
</span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="p"><span \
class="hl">()</span>,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">rightContext</span> <span class="o"><span class="hl">=</span></span><span \
class="hl"> </span><span class="n"><span class="hl">QString</span></span><span \
class="p"><span class="hl">())</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please put \
the & adjacent to the typename for consistency</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103106/diff/1/?file=40786#file40786line168" \
style="color: black; font-weight: bold; text-decoration: \
underline;">languages/xml/formatter/formatterplugin.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const \
QString& text, const KMimeType::Ptr& mime, const QString& leftContext, \
const QString& rightContext)</pre></td> <td colspan="2"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">167</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> \
<span class="n">FormatterPlugin</span><span class="o">::</span><span \
class="n">formatSourceWithStyle</span><span class="p">(</span><span \
class="n">SourceFormatterStyle</span> <span class="n">style</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">text</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">KMimeType</span><span class="o">::</span><span \
class="n">Ptr</span><span class="o"><span class="hl">&</span></span><span \
class="hl"> </span><span class="n">mime</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">leftContext</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">rightContext</span><span class="p"><span \
class="hl">)</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">168</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> <span \
class="n">FormatterPlugin</span><span class="o">::</span><span \
class="n">formatSourceWithStyle</span><span class="p">(</span><span \
class="n">SourceFormatterStyle</span> <span class="n">style</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">text</span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="k"><span \
class="hl">const</span></span><span class="hl"> </span><span class="n"><span \
class="hl">KUrl</span></span><span class="o"><span \
class="hl">&</span></span><span class="hl"> </span><span class="n"><span \
class="hl">url</span></span><span class="p">,</span> <span class="k">const</span> \
<span class="n">KMimeType</span><span class="o">::</span><span \
class="n">Ptr</span><span class="hl"> </span><span class="o"><span \
class="hl">&</span></span><span class="n">mime</span><span class="p">,</span> \
<span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">leftContext</span><span class="hl"> \
</span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="p"><span \
class="hl">()</span>,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">rightContext</span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QString</span></span><span class="p"><span \
class="hl">())</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">also here, \
& adjacent to the typename please</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103106/diff/1/?file=40789#file40789line55" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/phpformatter/formatterplugin.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">55</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">virtual</span> <span class="n">QString</span> <span \
class="n">formatSourceWithStyle</span><span class="p">(</span><span \
class="n">KDevelop</span><span class="o">::</span><span \
class="n">SourceFormatterStyle</span> <span class="p">,</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">text</span><span class="p">,</span> <span class="k">const</span> \
<span class="n">KMimeType</span><span class="o">::</span><span \
class="n">Ptr</span><span class="o"><span class="hl">&</span></span><span \
class="hl"> </span><span class="n">mime</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">leftContext</span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QString</span></span><span class="p"><span class="hl">()</span>,</span> \
<span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">rightContext</span><span class="hl"> \
</span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="p"><span \
class="hl">()</span>);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">55</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">virtual</span> <span \
class="n">QString</span> <span class="n">formatSourceWithStyle</span><span \
class="p">(</span><span class="n">KDevelop</span><span class="o">::</span><span \
class="n">SourceFormatterStyle</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">text</span><span class="p">,</span> <span class="k">const</span> \
<span class="n">K<span class="hl">Url</span></span><span class="o"><span \
class="hl">&</span></span><span class="hl"> </span><span class="n"><span \
class="hl">url</span></span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="k"><span class="hl">const</span></span><span \
class="hl"> </span><span class="n"><span class="hl">K</span>MimeType</span><span \
class="o">::</span><span class="n">Ptr</span> <span class="o"><span \
class="hl">&</span></span><span class="n">mime</span><span class="p">,</span> \
<span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">leftContext</span><span class="p">,</span> \
<span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">rightContext</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">again, \
please & adjacent to typename</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103106/diff/1/?file=40790#file40790line92" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/phpformatter/formatterplugin.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString FormatterPlugin::description() {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">92</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> \
<span class="n">FormatterPlugin</span><span class="o">::</span><span \
class="n">formatSource</span> <span class="p"><span class="hl">(</span></span><span \
class="hl"> </span><span class="k">const</span> <span class="n">QString</span><span \
class="o"><span class="hl">&</span></span><span class="hl"> </span><span \
class="n">text</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">KMimeType</span><span class="o">::</span><span class="n">Ptr</span><span \
class="o"><span class="hl">&</span></span><span class="hl"> </span><span \
class="n">mime</span><span class="p">,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">leftContext</span><span class="p">,</span> <span class="k">const</span> \
<span class="n">QString</span><span class="o">&</span> <span \
class="n">rightContext</span> <span class="p"><span class="hl">)</span></span><span \
class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">QString</span> <span class="n">FormatterPlugin</span><span \
class="o">::</span><span class="n">formatSource</span><span class="p"><span \
class="hl">(</span></span><span class="k">const</span> <span class="n">QString</span> \
<span class="o"><span class="hl">&</span></span><span class="n">text</span><span \
class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="k"><span class="hl">const</span></span><span class="hl"> </span><span \
class="n"><span class="hl">KUrl</span></span><span class="o"><span \
class="hl">&</span></span><span class="hl"> </span><span class="n"><span \
class="hl">url</span></span><span class="p">,</span> <span class="k">const</span> \
<span class="n">KMimeType</span><span class="o">::</span><span class="n">Ptr</span> \
<span class="o"><span class="hl">&</span></span><span class="n">mime</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">leftContext</span><span class="hl"> \
</span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="p"><span \
class="hl">()</span>,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">rightContext</span> <span class="o"><span class="hl">=</span></span><span \
class="hl"> </span><span class="n"><span class="hl">QString</span></span><span \
class="p"><span class="hl">())</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">& \
again... :)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103106/diff/1/?file=40790#file40790line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/phpformatter/formatterplugin.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const \
QString& text, const KMimeType::Ptr& mime, const QString& leftContext, \
const QString& rightContext)</pre></td> <td colspan="2"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">102</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> \
<span class="n">FormatterPlugin</span><span class="o">::</span><span \
class="n">formatSourceWithStyle</span><span class="p">(</span><span \
class="n">SourceFormatterStyle</span> <span class="n">style</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">text</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">KMimeType</span><span class="o">::</span><span \
class="n">Ptr</span><span class="o"><span class="hl">&</span></span><span \
class="hl"> </span><span class="n">mime</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">leftContext</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">rightContext</span><span class="p"><span \
class="hl">)</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">103</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="n">QString</span> <span \
class="n">FormatterPlugin</span><span class="o">::</span><span \
class="n">formatSourceWithStyle</span><span class="p">(</span><span \
class="n">SourceFormatterStyle</span> <span class="n">style</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">text</span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="k"><span \
class="hl">const</span></span><span class="hl"> </span><span class="n"><span \
class="hl">KUrl</span></span><span class="o"><span \
class="hl">&</span></span><span class="hl"> </span><span class="n"><span \
class="hl">url</span></span><span class="p">,</span> <span class="k">const</span> \
<span class="n">KMimeType</span><span class="o">::</span><span \
class="n">Ptr</span><span class="hl"> </span><span class="o"><span \
class="hl">&</span></span><span class="n">mime</span><span class="p">,</span> \
<span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">leftContext</span><span class="hl"> \
</span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="p"><span \
class="hl">()</span>,</span> <span class="k">const</span> <span \
class="n">QString</span><span class="o">&</span> <span \
class="n">rightContext</span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QString</span></span><span class="p"><span \
class="hl">())</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">& \
again... :)</pre> </div>
<br />
<p>- Milian</p>
<br />
<p>On November 10th, 2011, 12:05 p.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2011, 12:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some changes on the Interface of ISourceFormatter from the kdevplatform \
project broke compiling of quanta. This Patch fixes the interface of the \
SourceFormatter derived classes and some calls to these methods with the new KUrl \
parameter inserted.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Quanta compiles fine with that patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style="color: \
grey">(e8799f1)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style="color: \
grey">(4b04725)</span></li>
<li>languages/xml/formatter/sgmlformatter.cpp <span style="color: \
grey">(4a99d79)</span></li>
<li>languages/xml/language/completion/sgmlcodecompletionmodel.cpp <span \
style="color: grey">(803760f)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style="color: \
grey">(8b462bc)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style="color: \
grey">(761d635)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103106/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic