[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quanta-devel
Subject:    Re: [quanta-devel] [kde-freebsd]
From:       Adriaan de Groot <groot () kde ! org>
Date:       2005-12-21 6:27:01
Message-ID: 20051221082206.W25237 () hex ! athame ! co ! uk
[Download RAW message or body]

On Tue, 20 Dec 2005, David Johnson wrote:
> On Tuesday 20 December 2005 01:06 pm, Adriaan de Groot wrote:
>> SVN commit 490122 by adridg:
>> -  item->setText(VariablesListViewColumns::Value, (newvar->isScalar() ? oldvar->value() : ""));
>> +  item->setText(VariablesListViewColumns::Value, (newvar->isScalar() ? oldvar->value() : QString()));
>
> QString() creates a null string, not an empty string. While you're probably
> safe with listview items, there are some QString methods which will segfault
> on null QStrings.

Good nitpick. CC'ing quanta-devel so they're aware of the issue I may have 
caused here. QString() vs. "" is one of those nasty subtleties in the 
interface. If relevant, this should become QString::fromLatin1("") for 
greatest portability also in the face of QT_NO_CAST_ASCII.

[ade]
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]