[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quanta-devel
Subject:    Re: [quanta-devel] KDevelop-Quanta integration in CVS
From:       Jens Herden <jens () kdewebdev ! org>
Date:       2005-05-21 8:46:32
Message-ID: 200505211546.32627.jens () kdewebdev ! org
[Download RAW message or body]

Hi Andras,

> About the usertoolbars plugin:

I did a quick look into the code. And I got, as usual, something to ask:

Why do you put the toolbar in a QWidget before you put them into the 
tabwidget? From what I know is a KToolBar a QWidget, why can't you put it 
directly in the tabwidget?

In useraction there is a method execute(bool blocking) and I would suggest to 
add a default value for the blocking parameter. I think false would be good. 

The same useraction has a method toggled() that does nothing else as calling 
isChecked(). We should drop this.

I miss myprocess.cpp it is hidden inside of useraction.cpp! 

Jens
_______________________________________________
quanta-devel mailing list
quanta-devel@kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
[prev in list] [next in list] [prev in thread] [next in thread]