[prev in list] [next in list] [prev in thread] [next in thread] 

List:       quagga-dev
Subject:    [quagga-dev 6723] Re: Saving vtysh history into file
From:       Tomasz Pala <gotar () pld-linux ! org>
Date:       2009-06-25 8:58:03
Message-ID: 20090625085803.GA12186 () polanet ! pl
[Download RAW message or body]

On Wed, Jun 24, 2009 at 22:27:18 +0100, paul@jakma.org wrote:

>> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/quagga-snmp-manual.patch
> 
> Doesn't seem to apply to any file of ours?

Indeed, it's for http://www.net-track.ch/opensource/quagga-snmp/

>> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/quagga-proc.patch
> 
> This breaks non-Linux. I'd accept a patch that just checked for the 
> target being linux to set the required stuff, rather than checking 
> for /proc/...

I've forwarded this comment to the author as I don't understand AC/AM
magic myself.

>> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/quagga-link.patch
> 
> AFAIK, this shouldn't be needed. Applications should pull in the 

Yes, it looks like it's not required any longer. Thanks for applying
other patches:) There is also one more patch of mine:

http://cvs.pld-linux.org/cgi-bin/cvsweb/packages/quagga/quagga-readline.patch

without this vtysh linked against readline 6 behaves like this:

# sh[tab]
# show  (two spaces added)
# show  ip bgp comm[tab]
# show  ip bgp community (space added, while there are
               community-info and
               community-list command available)

because rl_completion_append_character='' isn't preserved as it probably
was in former versions of readline.

-- 
Tomasz Pala <gotar@pld-linux.org>
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev
[prev in list] [next in list] [prev in thread] [next in thread]