[prev in list] [next in list] [prev in thread] [next in thread] 

List:       qemu-ppc
Subject:    Re: [Qemu-ppc] [Qemu-devel] [PATCH 06/14] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_he
From:       Richard Henderson <richard.henderson () linaro ! org>
Date:       2019-04-30 16:41:37
Message-ID: 5a60992b-d6db-4761-38fa-bb413f69d3ae () linaro ! org
[Download RAW message or body]

On 4/28/19 7:38 AM, Mark Cave-Ayland wrote:
> Rather than perform the VSR register decoding within the helper itself,
> introduce a new GEN_VSX_HELPER_X2_AB macro which performs the decode based
> upon xA and xB at translation time.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  target/ppc/fpu_helper.c             | 15 ++++++---------
>  target/ppc/helper.h                 | 12 ++++++------
>  target/ppc/translate/vsx-impl.inc.c | 30 ++++++++++++++++++++++++------
>  3 files changed, 36 insertions(+), 21 deletions(-)

This time I see VSX_TDIV right away as a place that still
uses opcode.  It can certainly be cleaned up, but that's
a different patch.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


[prev in list] [next in list] [prev in thread] [next in thread]